RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 22:27:35 +00:00
Code Issues Activity Actions

LibWeb: Add m_page in TraversableNavigable

Browse source
This commit is contained in:
Aliaksandr Kalenik 2023-08-22 15:42:56 +02:00 • committed by Andreas Kling
parent 5a704453af
commit 343c709566
2 changed files with 11 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

7
Userland/Libraries/LibWeb/HTML/TraversableNavigable.cpp
View file

@ -16,7 +16,10 @@
namespace Web::HTML { namespace Web::HTML {
TraversableNavigable::TraversableNavigable() = default; TraversableNavigable::TraversableNavigable(Page& page)
: m_page(page)
{
}
TraversableNavigable::~TraversableNavigable() = default; TraversableNavigable::~TraversableNavigable() = default;
@ -76,7 +79,7 @@ WebIDL::ExceptionOr<JS::NonnullGCPtr<TraversableNavigable>> TraversableNavigable
document_state->set_navigable_target_name(target_name); document_state->set_navigable_target_name(target_name);
// 5. Let traversable be a new traversable navigable. // 5. Let traversable be a new traversable navigable.
auto traversable = vm.heap().allocate_without_realm<TraversableNavigable>(); auto traversable = vm.heap().allocate_without_realm<TraversableNavigable>(page);
// 6. Initialize the navigable traversable given documentState. // 6. Initialize the navigable traversable given documentState.
TRY_OR_THROW_OOM(vm, traversable->initialize_navigable(document_state, nullptr)); TRY_OR_THROW_OOM(vm, traversable->initialize_navigable(document_state, nullptr));

7
Userland/Libraries/LibWeb/HTML/TraversableNavigable.h
View file

@ -54,8 +54,11 @@ public:
m_session_history_traversal_queue.append(move(steps)); m_session_history_traversal_queue.append(move(steps));
} }
Page* page() { return m_page; }
Page const* page() const { return m_page; }
private: private:
TraversableNavigable(); TraversableNavigable(Page&);
virtual void visit_edges(Cell::Visitor&) override; virtual void visit_edges(Cell::Visitor&) override;
@ -74,6 +77,8 @@ private:
VisibilityState m_system_visibility_state { VisibilityState::Visible }; VisibilityState m_system_visibility_state { VisibilityState::Visible };
SessionHistoryTraversalQueue m_session_history_traversal_queue; SessionHistoryTraversalQueue m_session_history_traversal_queue;
WeakPtr<Page> m_page;
}; };
void finalize_a_same_document_navigation(JS::NonnullGCPtr<TraversableNavigable> traversable, JS::NonnullGCPtr<Navigable> target_navigable, JS::NonnullGCPtr<SessionHistoryEntry> target_entry, JS::GCPtr<SessionHistoryEntry> entry_to_replace); void finalize_a_same_document_navigation(JS::NonnullGCPtr<TraversableNavigable> traversable, JS::NonnullGCPtr<Navigable> target_navigable, JS::NonnullGCPtr<SessionHistoryEntry> target_entry, JS::GCPtr<SessionHistoryEntry> entry_to_replace);