RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 09:57:34 +00:00
Code Issues Activity Actions

LibWeb: Make Element::get_elements_by_class_name take a StringView

Browse source 
We only make use of the view of the view in this function.
This commit is contained in:
Shannon Booth 2023-09-21 20:32:09 +12:00 • committed by Andreas Kling
parent 79f97da4b4
commit 3458a53cb4
2 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibWeb/DOM/Element.cpp
View file

@ -748,10 +748,10 @@ bool Element::is_document_element() const
return document().document_element() == this; return document().document_element() == this;
} }
JS::NonnullGCPtr<HTMLCollection> Element::get_elements_by_class_name(DeprecatedFlyString const& class_names) JS::NonnullGCPtr<HTMLCollection> Element::get_elements_by_class_name(StringView class_names)
{ {
Vector<FlyString> list_of_class_names; Vector<FlyString> list_of_class_names;
for (auto& name : class_names.view().split_view_if(Infra::is_ascii_whitespace)) { for (auto& name : class_names.split_view_if(Infra::is_ascii_whitespace)) {
list_of_class_names.append(FlyString::from_utf8(name).release_value_but_fixme_should_propagate_errors()); list_of_class_names.append(FlyString::from_utf8(name).release_value_but_fixme_should_propagate_errors());
} }
return HTMLCollection::create(*this, HTMLCollection::Scope::Descendants, [list_of_class_names = move(list_of_class_names), quirks_mode = document().in_quirks_mode()](Element const& element) { return HTMLCollection::create(*this, HTMLCollection::Scope::Descendants, [list_of_class_names = move(list_of_class_names), quirks_mode = document().in_quirks_mode()](Element const& element) {

2
Userland/Libraries/LibWeb/DOM/Element.h
View file

@ -199,7 +199,7 @@ public:
bool is_target() const; bool is_target() const;
bool is_document_element() const; bool is_document_element() const;
JS::NonnullGCPtr<HTMLCollection> get_elements_by_class_name(DeprecatedFlyString const&); JS::NonnullGCPtr<HTMLCollection> get_elements_by_class_name(StringView);
bool is_shadow_host() const; bool is_shadow_host() const;
ShadowRoot* shadow_root_internal() { return m_shadow_root.ptr(); } ShadowRoot* shadow_root_internal() { return m_shadow_root.ptr(); }