RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 06:58:11 +00:00
Code Issues Activity Actions

LibWeb: Allow setting HTMLTableElement.tHead to null value

Browse source 
This deals with 2 FIXMEs :^)
This commit is contained in:
Andreas Kling 2022-12-15 20:04:44 +01:00
parent 2d791cf90f
commit 346737701d
1 changed files with 15 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

21
Userland/Libraries/LibWeb/HTML/HTMLTableElement.cpp
View file

@ -93,8 +93,11 @@ void HTMLTableElement::delete_caption()
} }
} }
// https://html.spec.whatwg.org/multipage/tables.html#dom-table-thead
JS::GCPtr<HTMLTableSectionElement> HTMLTableElement::t_head() JS::GCPtr<HTMLTableSectionElement> HTMLTableElement::t_head()
{ {
// The tHead IDL attribute must return, on getting, the first thead element child of the table element,
// if any, or null otherwise.
for (auto* child = first_child(); child; child = child->next_sibling()) { for (auto* child = first_child(); child; child = child->next_sibling()) {
if (is<HTMLTableSectionElement>(*child)) { if (is<HTMLTableSectionElement>(*child)) {
auto table_section_element = &verify_cast<HTMLTableSectionElement>(*child); auto table_section_element = &verify_cast<HTMLTableSectionElement>(*child);
@ -106,18 +109,24 @@ JS::GCPtr<HTMLTableSectionElement> HTMLTableElement::t_head()
return nullptr; return nullptr;
} }
// https://html.spec.whatwg.org/multipage/tables.html#dom-table-thead
WebIDL::ExceptionOr<void> HTMLTableElement::set_t_head(HTMLTableSectionElement* thead) WebIDL::ExceptionOr<void> HTMLTableElement::set_t_head(HTMLTableSectionElement* thead)
{ {
// FIXME: This is not always the case, but this function is currently written in a way that assumes non-null. // If the new value is neither null nor a thead element, then a "HierarchyRequestError" DOMException must be thrown instead.
VERIFY(thead); if (thead && thead->local_name() != TagNames::thead)
if (thead->local_name() != TagNames::thead)
return WebIDL::HierarchyRequestError::create(realm(), "Element is not thead"); return WebIDL::HierarchyRequestError::create(realm(), "Element is not thead");
// FIXME: The spec requires deleting the current thead if thead is null // On setting, if the new value is null or a thead element, the first thead element child of the table element,
// Currently the wrapper generator doesn't send us a nullable value // if any, must be removed,
delete_t_head(); delete_t_head();
if (!thead)
return {};
// and the new value, if not null, must be inserted immediately before the first element in the table element
// that is neither a caption element nor a colgroup element, if any,
// or at the end of the table if there are no such elements.
// We insert the new thead after any <caption> or <colgroup> elements // We insert the new thead after any <caption> or <colgroup> elements
DOM::Node* child_to_append_after = nullptr; DOM::Node* child_to_append_after = nullptr;
for (auto* child = first_child(); child; child = child->next_sibling()) { for (auto* child = first_child(); child; child = child->next_sibling()) {