RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 03:27:45 +00:00
Code Issues Activity Actions

LibWeb: Actually initialize ShadowRoot bindings

Browse source 
`mode` and `host` attributes were always undefined.
This commit is contained in:
Karol Kosek 2023-01-28 20:26:01 +01:00 • committed by Andreas Kling
parent d4cb089acb
commit 34913c48d3
2 changed files with 8 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

7
Userland/Libraries/LibWeb/DOM/ShadowRoot.cpp
View file

@ -18,6 +18,13 @@ ShadowRoot::ShadowRoot(Document& document, Element& host)
set_host(&host); set_host(&host);
} }
JS::ThrowCompletionOr<void> ShadowRoot::initialize(JS::Realm& realm)
{
MUST_OR_THROW_OOM(Base::initialize(realm));
set_prototype(&Bindings::ensure_web_prototype<Bindings::ShadowRootPrototype>(realm, "ShadowRoot"));
return {};
}
// https://dom.spec.whatwg.org/#ref-for-get-the-parent%E2%91%A6 // https://dom.spec.whatwg.org/#ref-for-get-the-parent%E2%91%A6
EventTarget* ShadowRoot::get_parent(Event const& event) EventTarget* ShadowRoot::get_parent(Event const& event)
{ {

1
Userland/Libraries/LibWeb/DOM/ShadowRoot.h
View file

@ -33,6 +33,7 @@ public:
private: private:
ShadowRoot(Document&, Element&); ShadowRoot(Document&, Element&);
virtual JS::ThrowCompletionOr<void> initialize(JS::Realm&) override;
// ^Node // ^Node
virtual DeprecatedFlyString node_name() const override { return "#shadow-root"; } virtual DeprecatedFlyString node_name() const override { return "#shadow-root"; }