RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 22:57:44 +00:00
Code Issues Activity Actions

LibJS: Account for negative numbers in ToTemporalDurationRecord

Browse source 
This is a normative change in the Temporal spec.

See: fa9d547
This commit is contained in:
Linus Groh 2021-09-02 19:09:09 +01:00
parent 0e6d503317
commit 3492fbf9cf
1 changed files with 3 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

13
Userland/Libraries/LibJS/Runtime/Temporal/Duration.cpp
View file

@ -110,21 +110,14 @@ TemporalDuration to_temporal_duration_record(GlobalObject& global_object, Object
if (vm.exception())
return {};
// iii. If val is NaN, +∞ or -∞, then
if (value.is_nan() || value.is_infinity()) {
// iii. If ! IsIntegralNumber(val) is false, then
if (!value.is_integral_number()) {
// 1. Throw a RangeError exception.
vm.throw_exception<RangeError>(global_object, ErrorType::TemporalInvalidDurationPropertyValueNonIntegral, property.as_string(), value.to_string_without_side_effects());
return {};
}
// iv. If floor(val) ≠ val, then
if (floor(value.as_double()) != value.as_double()) {
// 1. Throw a RangeError exception.
vm.throw_exception<RangeError>(global_object, ErrorType::TemporalInvalidDurationPropertyValueNonIntegral, property.as_string(), value.to_string_without_side_effects());
return {};
}
// v. Set result's internal slot whose name is the Internal Slot value of the current row to val.
// iv. Set result's internal slot whose name is the Internal Slot value of the current row to val.
result.*internal_slot = value.as_double();
}
}