RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 18:27:35 +00:00
Code Issues Activity Actions

LibWeb: Remove early resolve to auto while calculating border-box width

Browse source 
`Length::resolved(Node&)` transforms infinite values to "auto".

Following transformations:
Infinite (Length) -> "auto" -> 0 (px)
cause border-box width to be resolved in zero when it should be inf px.

Removing `Length::resolved(Node&)` makes it work right:
Infinite (Length) -> Infinite (px)

Fixes #18649
This commit is contained in:
Aliaksandr Kalenik 2023-05-05 09:45:19 +03:00 • committed by Andreas Kling
parent 2d2d2539b4
commit 34b1186272
3 changed files with 22 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Tests/LibWeb/Layout/expected/block-and-inline/max-width-percentage-100-border-box.txt Normal file
View file

@ -0,0 +1,8 @@
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (1,1) content-size 798x0 [BFC] children: not-inline
BlockContainer <body> at (10,10) content-size 93.59375x19.46875 positioned [BFC] children: not-inline
BlockContainer <nav> at (11,11) content-size 91.59375x17.46875 children: inline
line 0 width: 91.59375, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 10, rect: [11,11 91.59375x17.46875]
"border box"
TextNode <#text>