RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 17:47:44 +00:00
Code Issues Activity Actions

LibWeb: Verify that table cells have a paintable when collecting them

Browse source 
Replicate the more conservative way it's done for other nodes, for
which we verify whether they have a paintable before doing
painting-related operations with it.

Fixes crash on https://www.haiku-os.org/.
This commit is contained in:
Andi Gallo 2023-08-09 21:15:11 +00:00 • committed by Andreas Kling
parent 670bbf24e5
commit 34cd7f4c22
3 changed files with 22 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Userland/Libraries/LibWeb/Painting/TableBordersPainting.cpp
View file

@ -34,8 +34,9 @@ static void collect_cell_boxes(Vector<PaintableBox const*>& cell_boxes, Layout::
{
box.for_each_child([&](auto& child) {
if (child.display().is_table_cell()) {
VERIFY(is<Layout::Box>(child) && child.paintable());
cell_boxes.append(static_cast<Layout::Box const&>(child).paintable_box());
VERIFY(is<Layout::Box>(child));
if (child.paintable())
cell_boxes.append(static_cast<Layout::Box const&>(child).paintable_box());
} else {
collect_cell_boxes(cell_boxes, child);
}