RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 04:37:44 +00:00
Code Issues Activity Actions

LibCpp: Make the fields of AST node types private

Browse source 
Previously almost all fields were public and were directly accessed by
the Parser and CppComprehensionEngine.

This commit makes all fields of AST node types private. They are now
accessed via getters & setters.
This commit is contained in:
Itamar 2021-07-06 22:44:20 +03:00 • committed by Andreas Kling
parent d60bd42972
commit 34fc6c7e1c
4 changed files with 265 additions and 119 deletions
Download patch file Download diff file Expand all files Collapse all files

22
Userland/Libraries/LibCpp/AST.cpp
View file

@ -78,11 +78,11 @@ void Type::dump(FILE* output, size_t indent) const
String NamedType::to_string() const
{
String qualifiers_string;
if (!m_qualifiers.is_empty())
qualifiers_string = String::formatted("[{}] ", String::join(" ", m_qualifiers));
if (!qualifiers().is_empty())
qualifiers_string = String::formatted("[{}] ", String::join(" ", qualifiers()));
String name;
if (m_is_auto)
if (is_auto())
name = "auto";
else
name = m_name.is_null() ? "" : m_name->full_name();
@ -473,10 +473,10 @@ String Name::full_name() const
StringBuilder builder;
if (!m_scope.is_empty()) {
for (auto& scope : m_scope) {
builder.appendff("{}::", scope.m_name);
builder.appendff("{}::", scope.name());
}
}
return String::formatted("{}{}", builder.to_string(), m_name.is_null() ? "" : m_name->m_name);
return String::formatted("{}{}", builder.to_string(), m_name.is_null() ? "" : m_name->name());
}
String TemplatizedName::full_name() const
@ -539,13 +539,13 @@ void Constructor::dump(FILE* output, size_t indent) const
outln(output, "C'tor");
print_indent(output, indent + 1);
outln(output, "(");
for (const auto& arg : m_parameters) {
for (const auto& arg : parameters()) {
arg.dump(output, indent + 1);
}
print_indent(output, indent + 1);
outln(output, ")");
if (!m_definition.is_null()) {
m_definition->dump(output, indent + 1);
if (definition()) {
definition()->dump(output, indent + 1);
}
}
@ -555,13 +555,13 @@ void Destructor::dump(FILE* output, size_t indent) const
outln(output, "D'tor");
print_indent(output, indent + 1);
outln(output, "(");
for (const auto& arg : m_parameters) {
for (const auto& arg : parameters()) {
arg.dump(output, indent + 1);
}
print_indent(output, indent + 1);
outln(output, ")");
if (!m_definition.is_null()) {
m_definition->dump(output, indent + 1);
if (definition()) {
definition()->dump(output, indent + 1);
}
}