RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-16 22:55:06 +00:00
Code Issues Activity Actions

Kernel+SystemMonitor: Add fault counters

Browse source 
This patch adds three separate per-process fault counters:

- Inode faults

    An inode fault happens when we've memory-mapped a file from disk
    and we end up having to load 1 page (4KB) of the file into memory.

- Zero faults

    Memory returned by mmap() is lazily zeroed out. Every time we have
    to zero out 1 page, we count a zero fault.

- CoW faults

    VM objects can be shared by multiple mappings that make their own
    unique copy iff they want to modify it. The typical reason here is
    memory shared between a parent and child process.
This commit is contained in:
Andreas Kling 2019-10-02 14:13:49 +02:00
parent c33ac7f170
commit 35138437ef
7 changed files with 62 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

27
Applications/SystemMonitor/ProcessModel.cpp
View file

@ -54,6 +54,12 @@ String ProcessModel::column_name(int column) const
return "Name";
case Column::Syscalls:
return "Syscalls";
case Column::InodeFaults:
return "F:Inode";
case Column::ZeroFaults:
return "F:Zero";
case Column::CowFaults:
return "F:CoW";
default:
ASSERT_NOT_REACHED();
}
@ -82,6 +88,12 @@ GModel::ColumnMetadata ProcessModel::column_metadata(int column) const
return { 140, TextAlignment::CenterLeft };
case Column::Syscalls:
return { 60, TextAlignment::CenterRight };
case Column::InodeFaults:
return { 60, TextAlignment::CenterRight };
case Column::ZeroFaults:
return { 60, TextAlignment::CenterRight };
case Column::CowFaults:
return { 60, TextAlignment::CenterRight };
default:
ASSERT_NOT_REACHED();
}
@ -131,6 +143,12 @@ GVariant ProcessModel::data(const GModelIndex& index, Role role) const
// FIXME: GVariant with unsigned?
case Column::Syscalls:
return (int)process.current_state.syscall_count;
case Column::InodeFaults:
return (int)process.current_state.inode_faults;
case Column::ZeroFaults:
return (int)process.current_state.zero_faults;
case Column::CowFaults:
return (int)process.current_state.cow_faults;
}
ASSERT_NOT_REACHED();
return {};
@ -175,6 +193,12 @@ GVariant ProcessModel::data(const GModelIndex& index, Role role) const
// FIXME: It's weird that GVariant doesn't support unsigned ints. Should it?
case Column::Syscalls:
return (int)process.current_state.syscall_count;
case Column::InodeFaults:
return (int)process.current_state.inode_faults;
case Column::ZeroFaults:
return (int)process.current_state.zero_faults;
case Column::CowFaults:
return (int)process.current_state.cow_faults;
}
}
@ -198,6 +222,9 @@ void ProcessModel::update()
state.user = it.value.username;
state.priority = it.value.priority;
state.syscall_count = it.value.syscall_count;
state.inode_faults = it.value.inode_faults;
state.zero_faults = it.value.zero_faults;
state.cow_faults = it.value.cow_faults;
state.state = it.value.state;
state.name = it.value.name;
state.amount_virtual = it.value.amount_virtual;