RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-24 22:17:42 +00:00
Code Issues Activity Actions

LibGUI: Disable the ColumnsView subview in MultiView for now

Browse source 
This is causing FilePicker to log a bunch of debug noise due to the
missing support for tree models in SortingProxyModel and it's not
helping anyone so let's just disable it.

This needs fixing in SortingProxyModel.
This commit is contained in:
Andreas Kling 2020-02-27 14:41:49 +01:00
parent e52d1a02c8
commit 3523071bb7
3 changed files with 34 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

12
Libraries/LibGUI/MultiView.h
View file

@ -32,6 +32,8 @@
#include <LibGUI/StackWidget.h>
#include <LibGUI/TableView.h>
//#define MULTIVIEW_WITH_COLUMNSVIEW
namespace GUI {
class MultiView final : public GUI::StackWidget {
@ -65,8 +67,10 @@ public:
switch (m_view_mode) {
case ViewMode::List:
return *m_table_view;
#ifdef MULTIVIEW_WITH_COLUMNSVIEW
case ViewMode::Columns:
return *m_columns_view;
#endif
case ViewMode::Icon:
return *m_item_view;
default:
@ -82,7 +86,9 @@ public:
{
callback(*m_table_view);
callback(*m_item_view);
#ifdef MULTIVIEW_WITH_COLUMNSVIEW
callback(*m_columns_view);
#endif
}
Model* model() { return m_model; }
@ -92,7 +98,9 @@ public:
Action& view_as_table_action() { return *m_view_as_table_action; }
Action& view_as_icons_action() { return *m_view_as_icons_action; }
#ifdef MULTIVIEW_WITH_COLUMNSVIEW
Action& view_as_columns_action() { return *m_view_as_columns_action; }
#endif
private:
MultiView();
@ -106,11 +114,15 @@ private:
RefPtr<TableView> m_table_view;
RefPtr<ItemView> m_item_view;
#ifdef MULTIVIEW_WITH_COLUMNSVIEW
RefPtr<ColumnsView> m_columns_view;
#endif
RefPtr<Action> m_view_as_table_action;
RefPtr<Action> m_view_as_icons_action;
#ifdef MULTIVIEW_WITH_COLUMNSVIEW
RefPtr<Action> m_view_as_columns_action;
#endif
OwnPtr<ActionGroup> m_view_type_action_group;
};