RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 15:57:45 +00:00
Code Issues Activity Actions

LibWeb: Support fast_is<T>() for table, table sections, rows and cells

Browse source 
3.2x speed-up on WebKit/PerformanceTests/DOM/GridSort.html
This commit is contained in:
Andreas Kling 2023-08-22 14:55:10 +02:00
parent 76580bb9ba
commit 354d2ccc3c
5 changed files with 32 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibWeb/DOM/Node.h
View file

@ -95,6 +95,10 @@ public:
virtual bool is_html_progress_element() const { return false; } virtual bool is_html_progress_element() const { return false; }
virtual bool is_html_script_element() const { return false; } virtual bool is_html_script_element() const { return false; }
virtual bool is_html_template_element() const { return false; } virtual bool is_html_template_element() const { return false; }
virtual bool is_html_table_element() const { return false; }
virtual bool is_html_table_section_element() const { return false; }
virtual bool is_html_table_row_element() const { return false; }
virtual bool is_html_table_cell_element() const { return false; }
virtual bool is_navigable_container() const { return false; } virtual bool is_navigable_container() const { return false; }
WebIDL::ExceptionOr<JS::NonnullGCPtr<Node>> pre_insert(JS::NonnullGCPtr<Node>, JS::GCPtr<Node>); WebIDL::ExceptionOr<JS::NonnullGCPtr<Node>> pre_insert(JS::NonnullGCPtr<Node>, JS::GCPtr<Node>);

7
Userland/Libraries/LibWeb/HTML/HTMLTableCellElement.h
View file

@ -27,8 +27,15 @@ public:
private: private:
HTMLTableCellElement(DOM::Document&, DOM::QualifiedName); HTMLTableCellElement(DOM::Document&, DOM::QualifiedName);
virtual bool is_html_table_cell_element() const override { return true; }
virtual void initialize(JS::Realm&) override; virtual void initialize(JS::Realm&) override;
virtual void apply_presentational_hints(CSS::StyleProperties&) const override; virtual void apply_presentational_hints(CSS::StyleProperties&) const override;
}; };
} }
namespace Web::DOM {
template<>
inline bool Node::fast_is<HTML::HTMLTableCellElement>() const { return is_html_table_cell_element(); }
}

7
Userland/Libraries/LibWeb/HTML/HTMLTableElement.h
View file

@ -48,6 +48,8 @@ public:
private: private:
HTMLTableElement(DOM::Document&, DOM::QualifiedName); HTMLTableElement(DOM::Document&, DOM::QualifiedName);
virtual bool is_html_table_element() const override { return true; }
virtual void initialize(JS::Realm&) override; virtual void initialize(JS::Realm&) override;
virtual void visit_edges(Cell::Visitor&) override; virtual void visit_edges(Cell::Visitor&) override;
@ -58,3 +60,8 @@ private:
}; };
} }
namespace Web::DOM {
template<>
inline bool Node::fast_is<HTML::HTMLTableElement>() const { return is_html_table_element(); }
}

7
Userland/Libraries/LibWeb/HTML/HTMLTableRowElement.h
View file

@ -30,6 +30,8 @@ public:
private: private:
HTMLTableRowElement(DOM::Document&, DOM::QualifiedName); HTMLTableRowElement(DOM::Document&, DOM::QualifiedName);
virtual bool is_html_table_row_element() const override { return true; }
virtual void initialize(JS::Realm&) override; virtual void initialize(JS::Realm&) override;
virtual void visit_edges(Cell::Visitor&) override; virtual void visit_edges(Cell::Visitor&) override;
virtual void apply_presentational_hints(CSS::StyleProperties&) const override; virtual void apply_presentational_hints(CSS::StyleProperties&) const override;
@ -38,3 +40,8 @@ private:
}; };
} }
namespace Web::DOM {
template<>
inline bool Node::fast_is<HTML::HTMLTableRowElement>() const { return is_html_table_row_element(); }
}

7
Userland/Libraries/LibWeb/HTML/HTMLTableSectionElement.h
View file

@ -30,6 +30,8 @@ public:
private: private:
HTMLTableSectionElement(DOM::Document&, DOM::QualifiedName); HTMLTableSectionElement(DOM::Document&, DOM::QualifiedName);
virtual bool is_html_table_section_element() const override { return true; }
virtual void initialize(JS::Realm&) override; virtual void initialize(JS::Realm&) override;
virtual void visit_edges(Cell::Visitor&) override; virtual void visit_edges(Cell::Visitor&) override;
@ -37,3 +39,8 @@ private:
}; };
} }
namespace Web::DOM {
template<>
inline bool Node::fast_is<HTML::HTMLTableSectionElement>() const { return is_html_table_section_element(); }
}