mirror of
https://github.com/RGBCube/serenity
synced 2025-07-25 18:47:34 +00:00
AK+Everywhere: Change URL::path() to serialize_path()
This now defaults to serializing the path with percent decoded segments (which is what all callers expect), but has an option not to. This fixes `file://` URLs with spaces in their paths. The name has been changed to serialize_path() path to make it more clear that this method will generate a new string each call (except for the cannot_be_a_base_url() case). A few callers have then been updated to avoid repeatedly calling this function.
This commit is contained in:
parent
5acd40c525
commit
35612c6a7f
42 changed files with 131 additions and 123 deletions
|
@ -49,9 +49,9 @@ ErrorOr<ByteBuffer> HttpRequest::to_raw_request() const
|
|||
TRY(builder.try_append(method_name()));
|
||||
TRY(builder.try_append(' '));
|
||||
// NOTE: The percent_encode is so that e.g. spaces are properly encoded.
|
||||
auto path = m_url.path();
|
||||
auto path = m_url.serialize_path();
|
||||
VERIFY(!path.is_empty());
|
||||
TRY(builder.try_append(URL::percent_encode(m_url.path(), URL::PercentEncodeSet::EncodeURI)));
|
||||
TRY(builder.try_append(URL::percent_encode(path, URL::PercentEncodeSet::EncodeURI)));
|
||||
if (!m_url.query().is_empty()) {
|
||||
TRY(builder.try_append('?'));
|
||||
TRY(builder.try_append(m_url.query()));
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue