mirror of
https://github.com/RGBCube/serenity
synced 2025-07-27 08:07:34 +00:00
AK+Everywhere: Change URL::path() to serialize_path()
This now defaults to serializing the path with percent decoded segments (which is what all callers expect), but has an option not to. This fixes `file://` URLs with spaces in their paths. The name has been changed to serialize_path() path to make it more clear that this method will generate a new string each call (except for the cannot_be_a_base_url() case). A few callers have then been updated to avoid repeatedly calling this function.
This commit is contained in:
parent
5acd40c525
commit
35612c6a7f
42 changed files with 131 additions and 123 deletions
|
@ -243,13 +243,14 @@ void QuickLaunchWidget::drop_event(GUI::DropEvent& event)
|
|||
if (event.mime_data().has_urls()) {
|
||||
auto urls = event.mime_data().urls();
|
||||
for (auto& url : urls) {
|
||||
auto entry = QuickLaunchEntry::create_from_path(url.path());
|
||||
auto path = url.serialize_path();
|
||||
auto entry = QuickLaunchEntry::create_from_path(path);
|
||||
if (entry) {
|
||||
auto item_name = sanitize_entry_name(entry->name());
|
||||
auto result = add_or_adjust_button(item_name, entry.release_nonnull());
|
||||
if (result.is_error())
|
||||
GUI::MessageBox::show_error(window(), DeprecatedString::formatted("Failed to add quick launch entry: {}", result.release_error()));
|
||||
Config::write_string("Taskbar"sv, quick_launch, item_name, url.path());
|
||||
Config::write_string("Taskbar"sv, quick_launch, item_name, path);
|
||||
}
|
||||
}
|
||||
}
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue