From 35622606c195c0f85973425ceb9cb0b4616d30d4 Mon Sep 17 00:00:00 2001 From: Kenneth Myhra Date: Wed, 15 Feb 2023 20:29:21 +0100 Subject: [PATCH] LibWeb: Make factory method of URL::URLSearchParams fallible --- Userland/Libraries/LibWeb/URL/URLSearchParams.cpp | 4 ++-- Userland/Libraries/LibWeb/URL/URLSearchParams.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Userland/Libraries/LibWeb/URL/URLSearchParams.cpp b/Userland/Libraries/LibWeb/URL/URLSearchParams.cpp index 1d4eaa7f50..14ef8d01d6 100644 --- a/Userland/Libraries/LibWeb/URL/URLSearchParams.cpp +++ b/Userland/Libraries/LibWeb/URL/URLSearchParams.cpp @@ -89,9 +89,9 @@ Vector url_decode(StringView input) return output; } -JS::NonnullGCPtr URLSearchParams::create(JS::Realm& realm, Vector list) +WebIDL::ExceptionOr> URLSearchParams::create(JS::Realm& realm, Vector list) { - return realm.heap().allocate(realm, realm, move(list)).release_allocated_value_but_fixme_should_propagate_errors(); + return MUST_OR_THROW_OOM(realm.heap().allocate(realm, realm, move(list))); } // https://url.spec.whatwg.org/#dom-urlsearchparams-urlsearchparams diff --git a/Userland/Libraries/LibWeb/URL/URLSearchParams.h b/Userland/Libraries/LibWeb/URL/URLSearchParams.h index afe56d02d4..78b50826a5 100644 --- a/Userland/Libraries/LibWeb/URL/URLSearchParams.h +++ b/Userland/Libraries/LibWeb/URL/URLSearchParams.h @@ -23,7 +23,7 @@ class URLSearchParams : public Bindings::PlatformObject { WEB_PLATFORM_OBJECT(URLSearchParams, Bindings::PlatformObject); public: - static JS::NonnullGCPtr create(JS::Realm&, Vector list); + static WebIDL::ExceptionOr> create(JS::Realm&, Vector list); static WebIDL::ExceptionOr> construct_impl(JS::Realm&, Variant>, OrderedHashMap, DeprecatedString> const& init); virtual ~URLSearchParams() override;