RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 17:57:34 +00:00
Code Issues Activity Actions

Everywhere: Stop using NonnullOwnPtrVector

Browse source 
Same as NonnullRefPtrVector: weird semantics, questionable benefits.
This commit is contained in:
Andreas Kling 2023-03-06 17:16:25 +01:00
parent 689ca370d4
commit 359d6e7b0b
111 changed files with 517 additions and 503 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibXML/DOM/Node.cpp
View file

@ -44,7 +44,7 @@ bool Node::operator==(Node const& other) const
if (element.children.size() != other_element->children.size())
return false;
for (size_t i = 0; i < element.children.size(); ++i) {
if (element.children[i] != other_element->children[i])
if (element.children[i].ptr() != other_element->children[i].ptr())
return false;
}
return true;

2
Userland/Libraries/LibXML/DOM/Node.h
View file

@ -30,7 +30,7 @@ struct Node {
struct Element {
Name name;
HashMap<Name, DeprecatedString> attributes;
NonnullOwnPtrVector<Node> children;
Vector<NonnullOwnPtr<Node>> children;
};
bool operator==(Node const&) const;

2
Userland/Libraries/LibXML/Parser/Parser.cpp
View file

@ -95,7 +95,7 @@ void Parser::append_text(StringView text)
m_entered_node->content.visit(
[&](Node::Element& node) {
if (!node.children.is_empty()) {
auto* text_node = node.children.last().content.get_pointer<Node::Text>();
auto* text_node = node.children.last()->content.get_pointer<Node::Text>();
if (text_node) {
text_node->builder.append(text);
return;