RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 22:57:44 +00:00
Code Issues Activity Actions

Everywhere: Stop using NonnullOwnPtrVector

Browse source 
Same as NonnullRefPtrVector: weird semantics, questionable benefits.
This commit is contained in:
Andreas Kling 2023-03-06 17:16:25 +01:00
parent 689ca370d4
commit 359d6e7b0b
111 changed files with 517 additions and 503 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Userland/Services/WindowServer/Menu.h
View file

@ -40,8 +40,8 @@ public:
bool is_empty() const { return m_items.is_empty(); }
size_t item_count() const { return m_items.size(); }
MenuItem const& item(size_t index) const { return m_items.at(index); }
MenuItem& item(size_t index) { return m_items.at(index); }
MenuItem const& item(size_t index) const { return *m_items.at(index); }
MenuItem& item(size_t index) { return *m_items.at(index); }
MenuItem* item_by_identifier(unsigned identifier)
{
@ -65,7 +65,7 @@ public:
IterationDecision for_each_item(Callback callback)
{
for (auto& item : m_items) {
IterationDecision decision = callback(item);
IterationDecision decision = callback(*item);
if (decision != IterationDecision::Continue)
return decision;
}
@ -159,7 +159,7 @@ private:
u32 m_alt_shortcut_character { 0 };
Gfx::IntRect m_rect_in_window_menubar;
Gfx::IntPoint m_unadjusted_position;
NonnullOwnPtrVector<MenuItem> m_items;
Vector<NonnullOwnPtr<MenuItem>> m_items;
RefPtr<Window> m_menu_window;
WeakPtr<Window> m_window_menu_of;