RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 14:47:35 +00:00
Code Issues Activity Actions

Kernel: Move CommandLine API to use AK::StringView instead of AK::String

Browse source 
The current CommandLine API unfortunately allocates Strings just to
query the presence of arguments on the command line. Switch the API
to use StringView instead to reduce the number of String allocations.
This commit is contained in:
Brian Gianforcaro 2021-05-31 01:59:02 -07:00 • committed by Ali Mohammad Pur
parent 89dceb178b
commit 35a97884aa
2 changed files with 43 additions and 42 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Kernel/CommandLine.h
View file

@ -49,8 +49,8 @@ public:
static void initialize();
[[nodiscard]] const String& string() const { return m_string; }
Optional<String> lookup(const String& key) const;
[[nodiscard]] bool contains(const String& key) const;
Optional<String> lookup(const StringView& key) const;
[[nodiscard]] bool contains(const StringView& key) const;
[[nodiscard]] bool is_boot_profiling_enabled() const;
[[nodiscard]] bool is_ide_enabled() const;
@ -76,11 +76,11 @@ public:
private:
CommandLine(const String&);
void add_arguments(const Vector<String>& args);
void add_arguments(const Vector<StringView>& args);
void build_commandline(const String& cmdline_from_bootloader);
String m_string;
HashMap<String, String> m_params;
HashMap<StringView, StringView> m_params;
};
const CommandLine& kernel_command_line();