RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 01:57:45 +00:00
Code Issues Activity Actions

AK: Use __builtin_memset() and such to reduce header dependencies

Browse source 
We can use __builtin_memset() without including <string.h>.
This is pretty neat, as it will allow us to reduce the header deps
of AK templates a bit, if applied consistently.

Note that this is an enabling change for an upcoming #include removal.
This commit is contained in:
Andreas Kling 2020-03-08 11:57:24 +01:00
parent b1058b33fb
commit 35d88f536c
5 changed files with 14 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

8
AK/ByteBuffer.h
View file

@ -213,7 +213,7 @@ public:
{
int old_size = size();
grow(size() + data_size);
memcpy(this->data() + old_size, data, data_size);
__builtin_memcpy(this->data() + old_size, data, data_size);
}
private:
@ -237,7 +237,7 @@ inline ByteBufferImpl::ByteBufferImpl(const void* data, size_t size, Constructio
{
ASSERT(mode == Copy);
m_data = static_cast<u8*>(kmalloc(size));
memcpy(m_data, data, size);
__builtin_memcpy(m_data, data, size);
m_owned = true;
}
@ -257,7 +257,7 @@ inline void ByteBufferImpl::grow(size_t size)
ASSERT(size > m_size);
ASSERT(m_owned);
u8* new_data = static_cast<u8*>(kmalloc(size));
memcpy(new_data, m_data, m_size);
__builtin_memcpy(new_data, m_data, m_size);
u8* old_data = m_data;
m_data = new_data;
m_size = size;
@ -272,7 +272,7 @@ inline NonnullRefPtr<ByteBufferImpl> ByteBufferImpl::create_uninitialized(size_t
inline NonnullRefPtr<ByteBufferImpl> ByteBufferImpl::create_zeroed(size_t size)
{
auto buffer = ::adopt(*new ByteBufferImpl(size));
memset(buffer->data(), 0, size);
__builtin_memset(buffer->data(), 0, size);
return buffer;
}