RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 14:57:35 +00:00
Code Issues Activity Actions

Browser+LibGUI+WindowServer: Open Button menus uniformly

Browse source 
Instead of letting buttons determine the relative position
of their menus, a workaround only used by Statusbar segments,
open them all uniformly for a nice, consistent UI.

Passing a rect to popup() now routes to open_button_menu(), an
analog to open_menubar_menu(), which adjusts the menu's popup
position in the same way. Fixes button menus obscuring the buttons
which spawn them and jutting out at odd corners depending on screen
position.
This commit is contained in:
thankyouverycool 2022-09-04 19:48:37 -04:00 • committed by Linus Groh
parent 0fc1925cd7
commit 35e557c657
12 changed files with 34 additions and 31 deletions
Download patch file Download diff file Expand all files Collapse all files

7
Userland/Services/WindowServer/ConnectionFromClient.cpp
View file

@ -145,7 +145,7 @@ void ConnectionFromClient::add_menu_item(i32 menu_id, i32 identifier, i32 submen
menu.add_item(move(menu_item));
}
void ConnectionFromClient::popup_menu(i32 menu_id, Gfx::IntPoint const& screen_position)
void ConnectionFromClient::popup_menu(i32 menu_id, Gfx::IntPoint const& screen_position, Gfx::IntRect const& button_rect)
{
auto position = screen_position;
auto it = m_menus.find(menu_id);
@ -154,7 +154,10 @@ void ConnectionFromClient::popup_menu(i32 menu_id, Gfx::IntPoint const& screen_p
return;
}
auto& menu = *(*it).value;
menu.popup(position);
if (!button_rect.is_null())
menu.open_button_menu(position, button_rect);
else
menu.popup(position);
}
void ConnectionFromClient::dismiss_menu(i32 menu_id)