RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 23:17:46 +00:00
Code Issues Activity Actions

LibWeb: Fix infinite loop in ChildNode's before() and after()

Browse source 
The loop that was supposed to check the chain of previous or next
siblings had a logic mistake where it would never traverse the chain,
so we would get stuck looking at the immediate sibling forever.
This commit is contained in:
Andreas Kling 2024-03-11 15:27:23 +01:00
parent ad843b6e4a
commit 35f359c51c
5 changed files with 47 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Tests/LibWeb/Text/expected/DOM/ChildNode-after-next-sibling.txt Normal file
View file

@ -0,0 +1,5 @@
<DIV id="one" >
<DIV id="two" >
<DIV id="two" >
<DIV id="one" >
PASS (didn't crash)

5
Tests/LibWeb/Text/expected/DOM/ChildNode-before-previous-sibling.txt Normal file
View file

@ -0,0 +1,5 @@
<DIV id="one" >
<DIV id="two" >
<DIV id="two" >
<DIV id="one" >
PASS (didn't crash)