mirror of
https://github.com/RGBCube/serenity
synced 2025-07-27 05:27:45 +00:00
LibWeb: Remove implicit conversion from float and double to CSSPixels
In general it is not safe to convert any arbitrary floating-point value to CSSPixels. CSSPixels has a resolution of 0.015625, which for small values (e.g. scale factors between 0 and 1), can produce bad results if converted to CSSPixels then scaled back up. In the worst case values can underflow to zero and produce incorrect results.
This commit is contained in:
parent
0f9c088302
commit
360c0eb509
43 changed files with 248 additions and 221 deletions
|
@ -2,37 +2,37 @@ Viewport <#document> at (0,0) content-size 800x600 children: not-inline
|
|||
BlockContainer <html> at (0,0) content-size 800x616 [BFC] children: not-inline
|
||||
BlockContainer <body> at (8,8) content-size 784x600 children: not-inline
|
||||
Box <div.outer.row> at (8,8) content-size 150x150 flex-container(row) [FFC] children: not-inline
|
||||
BlockContainer <div.inner> at (12.625,8) content-size 30.078125x150 flex-item [BFC] children: inline
|
||||
BlockContainer <div.inner> at (12.609375,8) content-size 30.078125x150 flex-item [BFC] children: inline
|
||||
line 0 width: 30.078125, height: 17.46875, bottom: 17.46875, baseline: 13.53125
|
||||
frag 0 from TextNode start: 0, length: 4, rect: [12.625,8 30.078125x17.46875]
|
||||
frag 0 from TextNode start: 0, length: 4, rect: [12.609375,8 30.078125x17.46875]
|
||||
"Well"
|
||||
TextNode <#text>
|
||||
BlockContainer <div.inner> at (51.9375,8) content-size 36.84375x150 flex-item [BFC] children: inline
|
||||
BlockContainer <div.inner> at (51.921875,8) content-size 36.84375x150 flex-item [BFC] children: inline
|
||||
line 0 width: 36.84375, height: 17.46875, bottom: 17.46875, baseline: 13.53125
|
||||
frag 0 from TextNode start: 0, length: 5, rect: [51.9375,8 36.84375x17.46875]
|
||||
frag 0 from TextNode start: 0, length: 5, rect: [51.921875,8 36.84375x17.46875]
|
||||
"hello"
|
||||
TextNode <#text>
|
||||
BlockContainer <div.inner> at (98.015625,8) content-size 55.359375x150 flex-item [BFC] children: inline
|
||||
BlockContainer <div.inner> at (98,8) content-size 55.359375x150 flex-item [BFC] children: inline
|
||||
line 0 width: 55.359375, height: 17.46875, bottom: 17.46875, baseline: 13.53125
|
||||
frag 0 from TextNode start: 0, length: 7, rect: [98.015625,8 55.359375x17.46875]
|
||||
frag 0 from TextNode start: 0, length: 7, rect: [98,8 55.359375x17.46875]
|
||||
"friends"
|
||||
TextNode <#text>
|
||||
BlockContainer <(anonymous)> at (8,158) content-size 784x0 children: inline
|
||||
TextNode <#text>
|
||||
Box <div.outer.row-reverse> at (8,158) content-size 150x150 flex-container(row-reverse) [FFC] children: not-inline
|
||||
BlockContainer <div.inner> at (123.296875,158) content-size 30.078125x150 flex-item [BFC] children: inline
|
||||
BlockContainer <div.inner> at (123.3125,158) content-size 30.078125x150 flex-item [BFC] children: inline
|
||||
line 0 width: 30.078125, height: 17.46875, bottom: 17.46875, baseline: 13.53125
|
||||
frag 0 from TextNode start: 0, length: 4, rect: [123.296875,158 30.078125x17.46875]
|
||||
frag 0 from TextNode start: 0, length: 4, rect: [123.3125,158 30.078125x17.46875]
|
||||
"Well"
|
||||
TextNode <#text>
|
||||
BlockContainer <div.inner> at (77.21875,158) content-size 36.84375x150 flex-item [BFC] children: inline
|
||||
BlockContainer <div.inner> at (77.234375,158) content-size 36.84375x150 flex-item [BFC] children: inline
|
||||
line 0 width: 36.84375, height: 17.46875, bottom: 17.46875, baseline: 13.53125
|
||||
frag 0 from TextNode start: 0, length: 5, rect: [77.21875,158 36.84375x17.46875]
|
||||
frag 0 from TextNode start: 0, length: 5, rect: [77.234375,158 36.84375x17.46875]
|
||||
"hello"
|
||||
TextNode <#text>
|
||||
BlockContainer <div.inner> at (12.625,158) content-size 55.359375x150 flex-item [BFC] children: inline
|
||||
BlockContainer <div.inner> at (12.640625,158) content-size 55.359375x150 flex-item [BFC] children: inline
|
||||
line 0 width: 55.359375, height: 17.46875, bottom: 17.46875, baseline: 13.53125
|
||||
frag 0 from TextNode start: 0, length: 7, rect: [12.625,158 55.359375x17.46875]
|
||||
frag 0 from TextNode start: 0, length: 7, rect: [12.640625,158 55.359375x17.46875]
|
||||
"friends"
|
||||
TextNode <#text>
|
||||
BlockContainer <(anonymous)> at (8,308) content-size 784x0 children: inline
|
||||
|
@ -76,19 +76,19 @@ ViewportPaintable (Viewport<#document>) [0,0 800x600] overflow: [0,0 800x616]
|
|||
PaintableWithLines (BlockContainer<HTML>) [0,0 800x616]
|
||||
PaintableWithLines (BlockContainer<BODY>) [8,8 784x600]
|
||||
PaintableBox (Box<DIV>.outer.row) [8,8 150x150]
|
||||
PaintableWithLines (BlockContainer<DIV>.inner) [12.625,8 30.078125x150]
|
||||
PaintableWithLines (BlockContainer<DIV>.inner) [12.609375,8 30.078125x150]
|
||||
TextPaintable (TextNode<#text>)
|
||||
PaintableWithLines (BlockContainer<DIV>.inner) [51.9375,8 36.84375x150]
|
||||
PaintableWithLines (BlockContainer<DIV>.inner) [51.921875,8 36.84375x150]
|
||||
TextPaintable (TextNode<#text>)
|
||||
PaintableWithLines (BlockContainer<DIV>.inner) [98.015625,8 55.359375x150]
|
||||
PaintableWithLines (BlockContainer<DIV>.inner) [98,8 55.359375x150]
|
||||
TextPaintable (TextNode<#text>)
|
||||
PaintableWithLines (BlockContainer(anonymous)) [8,158 784x0]
|
||||
PaintableBox (Box<DIV>.outer.row-reverse) [8,158 150x150]
|
||||
PaintableWithLines (BlockContainer<DIV>.inner) [123.296875,158 30.078125x150]
|
||||
PaintableWithLines (BlockContainer<DIV>.inner) [123.3125,158 30.078125x150]
|
||||
TextPaintable (TextNode<#text>)
|
||||
PaintableWithLines (BlockContainer<DIV>.inner) [77.21875,158 36.84375x150]
|
||||
PaintableWithLines (BlockContainer<DIV>.inner) [77.234375,158 36.84375x150]
|
||||
TextPaintable (TextNode<#text>)
|
||||
PaintableWithLines (BlockContainer<DIV>.inner) [12.625,158 55.359375x150]
|
||||
PaintableWithLines (BlockContainer<DIV>.inner) [12.640625,158 55.359375x150]
|
||||
TextPaintable (TextNode<#text>)
|
||||
PaintableWithLines (BlockContainer(anonymous)) [8,308 784x0]
|
||||
PaintableBox (Box<DIV>.outer.column) [8,308 150x150]
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue