RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 12:07:45 +00:00
Code Issues Activity Actions

Meta: Fix debug-flag detection

Browse source 
Detection broke when we moved from '#ifdef DEBUG_FOO dbgln()' to 'dbgln<DEBUG_FOO>()'.
This patch makes detection more general, which sadly runs into more false-positives.

No rotten code was found, hooray! :^)
This commit is contained in:
Ben Wiederhake 2021-02-13 12:46:22 +01:00 • committed by Andreas Kling
parent c2e5bc442d
commit 363cc09091
2 changed files with 12 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Meta/CMake/all_the_debug_macros.cmake
View file

@ -170,7 +170,15 @@ set(SYSCALL_1_DEBUG ON)
# False positive: DEBUG is a flag but it works differently. # False positive: DEBUG is a flag but it works differently.
# set(DEBUG ON) # set(DEBUG ON)
# False positive: DT_DEBUG is a flag, but for a bitset, not a feature.
# set(DT_DEBUG ON)
# False positive: GUI_DND_DEBUG is a flag, but passed as an envvar.
# set(GUI_DND_DEBUG ON)
# False positive: GUI_FOCUS_DEBUG is a flag, but passed as an envvar.
# set(GUI_FOCUS_DEBUG ON)
# False positive: LOG_DEBUG is a flag, but for a bitset, not a feature. # False positive: LOG_DEBUG is a flag, but for a bitset, not a feature.
# set(LOG_DEBUG ON) # set(LOG_DEBUG ON)
# False positive: UHCI_USBCMD_SOFTWARE_DEBUG is a flag, but for a bitset, not a feature.
# set(UHCI_USBCMD_SOFTWARE_DEBUG ON)
# Clogs up build: The WrapperGenerator stuff is run at compile time. # Clogs up build: The WrapperGenerator stuff is run at compile time.
# set(WRAPPER_GENERATOR_DEBUG ON) # set(WRAPPER_GENERATOR_DEBUG ON)

8
Meta/check-debug-flags.sh
View file

@ -12,7 +12,7 @@ while IFS= read -r FLAG; do
# There are (basically) no false positives, but there might be false negatives, # There are (basically) no false positives, but there might be false negatives,
# for example we intentionally don't check for commented-out lines here. # for example we intentionally don't check for commented-out lines here.
if ! grep -qP "set\(${FLAG}" Meta/CMake/all_the_debug_macros.cmake ; then if ! grep -qP "set\(${FLAG}" Meta/CMake/all_the_debug_macros.cmake ; then
echo "ALL_THE_DEBUG_MACROS probably doesn't include ${FLAG}" echo "'all_the_debug_macros.cmake' is missing ${FLAG}"
MISSING_FLAGS=y MISSING_FLAGS=y
fi fi
done < <( done < <(
@ -22,16 +22,16 @@ done < <(
'*.in' \ '*.in' \
':!:Kernel/FileSystem/ext2_fs.h' \ ':!:Kernel/FileSystem/ext2_fs.h' \
':!:Userland/Libraries/LibELF/exec_elf.h' \ ':!:Userland/Libraries/LibELF/exec_elf.h' \
| xargs grep -P '^ *#.*DEBUG' \ | xargs grep -P '(_DEBUG|DEBUG_)' \
| sed -re 's,^.*[^a-zA-Z0-9_]([a-zA-Z0-9_]*DEBUG[a-zA-Z0-9_]*).*$,\1,' \ | sed -re 's,^.*[^a-zA-Z0-9_]([a-zA-Z0-9_]*DEBUG[a-zA-Z0-9_]*).*$,\1,' \
| sort \ | sort \
| uniq | uniq
) )
if [ "n" != "${MISSING_FLAGS}" ] ; then if [ "n" != "${MISSING_FLAGS}" ] ; then
echo "Some flags are missing for the ALL_THE_DEBUG_MACROS feature in CMakeLists.txt." echo "Some flags are missing for the ALL_THE_DEBUG_MACROS feature."
echo "If you just added a new SOMETHING_DEBUG flag, that's great!" echo "If you just added a new SOMETHING_DEBUG flag, that's great!"
echo "We want to enable all of these in automated builds, so that the code doesn't rot." echo "We want to enable all of these in automated builds, so that the code doesn't rot."
echo "Please add it to the ALL_THE_DEBUG_MACROS section." echo "Please add it to Meta/CMake/all_the_debug_macros.cmake"
exit 1 exit 1
fi fi