From 3645861f31c9c3cff71c50a1cf74172915ae67d6 Mon Sep 17 00:00:00 2001 From: Liav A Date: Fri, 23 Jul 2021 15:49:03 +0300 Subject: [PATCH] Kernel: Put a note about the unconditional unblanking of bochs-display This removes the FIXME note and explains why it's not so bad to do this. --- Kernel/Graphics/Bochs/GraphicsAdapter.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Kernel/Graphics/Bochs/GraphicsAdapter.cpp b/Kernel/Graphics/Bochs/GraphicsAdapter.cpp index 3aec96cfa4..fd254dd045 100644 --- a/Kernel/Graphics/Bochs/GraphicsAdapter.cpp +++ b/Kernel/Graphics/Bochs/GraphicsAdapter.cpp @@ -78,9 +78,9 @@ UNMAP_AFTER_INIT BochsGraphicsAdapter::BochsGraphicsAdapter(PCI::Address pci_add if (id.vendor_id == 0x80ee && id.device_id == 0xbeef) m_io_required = true; - // FIXME: Although this helps with setting the screen to work on some cases, - // we need to check we actually can access the VGA MMIO remapped ioports before - // doing the unblanking. + // Note: According to Gerd Hoffmann - "The linux driver simply does + // the unblank unconditionally. With bochs-display this is not needed but + // it also has no bad side effect". unblank(); set_safe_resolution(); }