RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-23 06:47:40 +00:00
Code Issues Activity Actions

Kernel: Make sure to drop region with interrupts enabled

Browse source 
A region can drop an inode if it was mmaped from the inode and held the last
reference to it, and that may require some locking.
This commit is contained in:
Sergey Bugaev 2020-07-02 11:53:19 +03:00 • committed by Andreas Kling
parent 6111cfda73
commit 3645b9e2a6
1 changed files with 3 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Kernel/Process.cpp
View file

@ -232,12 +232,14 @@ Region* Process::allocate_region_with_vmobject(VirtualAddress vaddr, size_t size
bool Process::deallocate_region(Region& region) bool Process::deallocate_region(Region& region)
{ {
OwnPtr<Region> region_protector;
ScopedSpinLock lock(m_lock); ScopedSpinLock lock(m_lock);
if (m_region_lookup_cache.region == &region) if (m_region_lookup_cache.region == &region)
m_region_lookup_cache.region = nullptr; m_region_lookup_cache.region = nullptr;
for (size_t i = 0; i < m_regions.size(); ++i) { for (size_t i = 0; i < m_regions.size(); ++i) {
if (&m_regions[i] == &region) { if (&m_regions[i] == &region) {
m_regions.unstable_take(i); region_protector = m_regions.unstable_take(i);
return true; return true;
} }
} }