RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 15:57:45 +00:00
Code Issues Activity Actions

Kernel: Remove the Socket::{protocol,}connect ShouldBlock argument

Browse source 
This argument is always set to description.is_blocking(), but
description is also given as a separate argument, so there's no point
to piping it through separately.
This commit is contained in:
Idan Horowitz 2022-07-13 09:31:24 +03:00 • committed by Andreas Kling
parent 2aaaee6744
commit 364f6a9bf0
10 changed files with 13 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

7
Kernel/Net/Socket.h
View file

@ -18,11 +18,6 @@
namespace Kernel {
enum class ShouldBlock {
No = 0,
Yes = 1
};
class OpenFileDescription;
class Socket : public File {
@ -79,7 +74,7 @@ public:
ErrorOr<void> shutdown(int how);
virtual ErrorOr<void> bind(Userspace<sockaddr const*>, socklen_t) = 0;
virtual ErrorOr<void> connect(OpenFileDescription&, Userspace<sockaddr const*>, socklen_t, ShouldBlock) = 0;
virtual ErrorOr<void> connect(OpenFileDescription&, Userspace<sockaddr const*>, socklen_t) = 0;
virtual ErrorOr<void> listen(size_t) = 0;
virtual void get_local_address(sockaddr*, socklen_t*) = 0;
virtual void get_peer_address(sockaddr*, socklen_t*) = 0;