From 368d2ace551ee3900ab7351d1ffdef477821af1f Mon Sep 17 00:00:00 2001 From: Andrew Kaster Date: Mon, 6 Sep 2021 18:06:46 -0600 Subject: [PATCH] Meta: Add FIXME for not setting BUILD_SHARED_LIBS in Lagom build This is really the business of the consuming project. We will need to make changes to libjs-test262 and to oss-fuzz to address this properly. --- Meta/Lagom/CMakeLists.txt | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/Meta/Lagom/CMakeLists.txt b/Meta/Lagom/CMakeLists.txt index e9f02ac40c..39f29061a8 100644 --- a/Meta/Lagom/CMakeLists.txt +++ b/Meta/Lagom/CMakeLists.txt @@ -38,9 +38,16 @@ if(ENABLE_ALL_THE_DEBUG_MACROS) include(all_the_debug_macros) endif() +# FIXME: BUILD_SHARED_LIBS has a default of OFF, as it's intended to be set by the +# user when configuring the project. We should instead change libjs-test262 +# and oss-fuzz to set this option on their end, and enable it by default in +# Meta/serenity.sh +# This is #9867. We can change the oss-fuzz escape hatch to be a FATAL_ERROR +# message instead when implementing it. option(BUILD_SHARED_LIBS "Build shared libraries instead of static libraries" ON) if (ENABLE_OSS_FUZZ) - set(BUILD_SHARED_LIBS OFF) # Don't use shared libraries on oss-fuzz, for ease of integration with their infrastructure + # Don't use shared libraries on oss-fuzz, for ease of integration with their infrastructure + set(BUILD_SHARED_LIBS OFF CACHE BOOL "Build shared libraries instead of static libraries" FORCE) endif() find_package(Threads REQUIRED)