From 36c738d9bf5089875c769edf17fec249df15dc9a Mon Sep 17 00:00:00 2001 From: Linus Groh Date: Tue, 11 Aug 2020 17:45:57 +0200 Subject: [PATCH] LibJS: Assert when exception is not cleared before Interpreter::run() This is to prevent bugs like #3091 (fixed in 9810f8872c21eaf2aefff25347d957cd26f34c2d) in the future; we generally don't want Interpreter::run() to be called if the interpreter still has an exception stored. Sure, it could clear those itself but letting users of the interpreter do it explicitly seems sensible. --- Libraries/LibJS/Interpreter.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Libraries/LibJS/Interpreter.cpp b/Libraries/LibJS/Interpreter.cpp index e00fa47c45..5c9836789b 100644 --- a/Libraries/LibJS/Interpreter.cpp +++ b/Libraries/LibJS/Interpreter.cpp @@ -60,6 +60,8 @@ Interpreter::~Interpreter() Value Interpreter::run(GlobalObject& global_object, const Statement& statement, ArgumentVector arguments, ScopeType scope_type) { + ASSERT(!exception()); + if (statement.is_program()) { if (m_call_stack.is_empty()) { CallFrame global_call_frame;