RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 05:47:35 +00:00
Code Issues Activity Actions

LibPDF: Allow page objects to inherit the MediaBox and Resources entries

Browse source
This commit is contained in:
Julian Offenhäuser 2022-08-25 10:36:36 +02:00 • committed by Andreas Kling
parent 2f71e0f09a
commit 36f83cecab
2 changed files with 13 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

18
Userland/Libraries/LibPDF/Document.cpp
View file

@ -109,15 +109,10 @@ PDFErrorOr<Page> Document::get_page(u32 index)
auto page_object = TRY(get_or_load_value(page_object_index));
auto raw_page_object = TRY(resolve_to<DictObject>(page_object));
if (!raw_page_object->contains(CommonNames::Resources)) {
// This page inherits its resource dictionary
TODO();
}
auto resources = TRY(raw_page_object->get_dict(this, CommonNames::Resources));
auto resources = TRY(get_inheritable_object(CommonNames::Resources, raw_page_object))->cast<DictObject>();
auto contents = TRY(raw_page_object->get_object(this, CommonNames::Contents));
auto media_box_array = TRY(raw_page_object->get_array(this, CommonNames::MediaBox));
auto media_box_array = TRY(get_inheritable_object(CommonNames::MediaBox, raw_page_object))->cast<ArrayObject>();
auto media_box = Rectangle {
media_box_array->at(0).to_float(),
media_box_array->at(1).to_float(),
@ -262,6 +257,15 @@ PDFErrorOr<Destination> Document::create_destination_from_parameters(NonnullRefP
return Destination { type, page_ref, parameters };
}
PDFErrorOr<NonnullRefPtr<Object>> Document::get_inheritable_object(FlyString const& name, NonnullRefPtr<DictObject> object)
{
if (!object->contains(name)) {
auto parent = TRY(object->get_dict(this, CommonNames::Parent));
return get_inheritable_object(name, parent);
}
return object->get_object(this, name);
}
PDFErrorOr<NonnullRefPtr<OutlineItem>> Document::build_outline_item(NonnullRefPtr<DictObject> const& outline_item_dict)
{
auto outline_item = adopt_ref(*new OutlineItem {});

2
Userland/Libraries/LibPDF/Document.h
View file

@ -150,6 +150,8 @@ private:
PDFErrorOr<Destination> create_destination_from_parameters(NonnullRefPtr<ArrayObject>);
PDFErrorOr<NonnullRefPtr<Object>> get_inheritable_object(FlyString const& name, NonnullRefPtr<DictObject>);
NonnullRefPtr<DocumentParser> m_parser;
RefPtr<DictObject> m_catalog;
RefPtr<DictObject> m_trailer;