RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 11:57:35 +00:00
Code Issues Activity Actions

LibWeb: Change the type of MouseEvent members to double

Browse source 
These are defined as integers only in the legacy specification, the
new one defines these as doubles.
This commit is contained in:
Idan Horowitz 2021-10-01 20:44:50 +03:00 • committed by Andreas Kling
parent f74b612aa4
commit 37586f61be
2 changed files with 12 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibWeb/UIEvents/MouseEvent.cpp
View file

@ -10,7 +10,7 @@
namespace Web::UIEvents { namespace Web::UIEvents {
MouseEvent::MouseEvent(const FlyString& event_name, i32 offset_x, i32 offset_y, i32 client_x, i32 client_y) MouseEvent::MouseEvent(const FlyString& event_name, double offset_x, double offset_y, double client_x, double client_y)
: UIEvent(event_name) : UIEvent(event_name)
, m_offset_x(offset_x) , m_offset_x(offset_x)
, m_offset_y(offset_y) , m_offset_y(offset_y)

21
Userland/Libraries/LibWeb/UIEvents/MouseEvent.h
View file

@ -7,6 +7,7 @@
#pragma once #pragma once
#include <AK/TypeCasts.h> #include <AK/TypeCasts.h>
#include <LibWeb/UIEvents/EventModifier.h>
#include <LibWeb/UIEvents/UIEvent.h> #include <LibWeb/UIEvents/UIEvent.h>
namespace Web::UIEvents { namespace Web::UIEvents {
@ -15,28 +16,28 @@ class MouseEvent final : public UIEvent {
public: public:
using WrapperType = Bindings::MouseEventWrapper; using WrapperType = Bindings::MouseEventWrapper;
static NonnullRefPtr<MouseEvent> create(const FlyString& event_name, i32 offset_x, i32 offset_y, i32 client_x, i32 client_y) static NonnullRefPtr<MouseEvent> create(const FlyString& event_name, double offset_x, double offset_y, double client_x, double client_y)
{ {
return adopt_ref(*new MouseEvent(event_name, offset_x, offset_y, client_x, client_y)); return adopt_ref(*new MouseEvent(event_name, offset_x, offset_y, client_x, client_y));
} }
virtual ~MouseEvent() override; virtual ~MouseEvent() override;
i32 offset_x() const { return m_offset_x; } double offset_x() const { return m_offset_x; }
i32 offset_y() const { return m_offset_y; } double offset_y() const { return m_offset_y; }
i32 client_x() const { return m_client_x; } double client_x() const { return m_client_x; }
i32 client_y() const { return m_client_y; } double client_y() const { return m_client_y; }
protected: protected:
MouseEvent(const FlyString& event_name, i32 offset_x, i32 offset_y, i32 client_x, i32 client_y); MouseEvent(const FlyString& event_name, double offset_x, double offset_y, double client_x, double client_y);
private: private:
void set_event_characteristics(); void set_event_characteristics();
i32 m_offset_x { 0 }; double m_offset_x { 0 };
i32 m_offset_y { 0 }; double m_offset_y { 0 };
i32 m_client_x { 0 }; double m_client_x { 0 };
i32 m_client_y { 0 }; double m_client_y { 0 };
}; };
} }