RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 01:27:42 +00:00
Code Issues Activity Actions

TTY: Properly implement echo in VirtualConsole.

Browse source 
VirtualConsole::echo now actually echoes characters
instead of doing nothing.
This commit is contained in:
Drew Stratford 2019-10-31 01:11:41 +13:00 • committed by Andreas Kling
parent ed45f67c00
commit 378480e8e4
2 changed files with 8 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

7
Kernel/TTY/VirtualConsole.cpp
View file

@ -545,6 +545,13 @@ StringView VirtualConsole::tty_name() const
return m_tty_name; return m_tty_name;
} }
void VirtualConsole::echo(u8 ch)
{
if (should_echo_input()) {
on_tty_write(&ch, 1);
}
}
void VirtualConsole::set_vga_start_row(u16 row) void VirtualConsole::set_vga_start_row(u16 row)
{ {
m_vga_start_row = row; m_vga_start_row = row;

2
Kernel/TTY/VirtualConsole.h
View file

@ -33,7 +33,7 @@ private:
// ^TTY // ^TTY
virtual ssize_t on_tty_write(const u8*, ssize_t) override; virtual ssize_t on_tty_write(const u8*, ssize_t) override;
virtual StringView tty_name() const override; virtual StringView tty_name() const override;
virtual void echo(u8) override { return; } virtual void echo(u8) override;
// ^CharacterDevice // ^CharacterDevice
virtual const char* class_name() const override { return "VirtualConsole"; } virtual const char* class_name() const override { return "VirtualConsole"; }