RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 09:38:11 +00:00
Code Issues Activity Actions

LibC: Use gethostbyname_r() in getaddrinfo()

Browse source 
getaddrinfo() used to use gethostbyname() which isn't MT-Safe.
This commit is contained in:
Marcus Nilsson 2023-08-12 22:08:10 +02:00 • committed by Andrew Kaster
parent db2f96e4ed
commit 37cea81837
1 changed files with 22 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

25
Userland/Libraries/LibC/netdb.cpp
View file

@ -783,9 +783,28 @@ int getaddrinfo(char const* __restrict node, char const* __restrict service, con
node = "127.0.0.1"; node = "127.0.0.1";
} }
auto host_ent = gethostbyname(node); size_t buffer_size = 1024;
if (!host_ent) char* buffer = nullptr;
return EAI_FAIL; int gethostbyname_errno = 0;
struct hostent ret = {};
struct hostent* host_ent = nullptr;
while (true) {
buffer = (char*)realloc(buffer, buffer_size);
if (buffer == nullptr)
return EAI_MEMORY;
int rc = gethostbyname_r(node, &ret, buffer, buffer_size, &host_ent, &gethostbyname_errno);
if (rc == ERANGE) {
buffer_size *= 2;
continue;
}
if (!host_ent)
return EAI_FAIL;
break;
}
char const* proto = nullptr; char const* proto = nullptr;
if (hints && hints->ai_socktype) { if (hints && hints->ai_socktype) {