RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-24 15:07:45 +00:00
Code Issues Activity Actions

LibWeb: Do not unload during same-document history step application

Browse source 
See https://github.com/whatwg/html/pull/9904
This commit is contained in:
Aliaksandr Kalenik 2023-11-02 10:09:01 +01:00 • committed by Andreas Kling
parent 67566e5017
commit 38531ce7cf
1 changed files with 11 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

19
Userland/Libraries/LibWeb/HTML/TraversableNavigable.cpp
View file

@ -424,15 +424,18 @@ void TraversableNavigable::apply_the_history_step(int step, Optional<SourceSnaps
// 1. If changingNavigableContinuation's update-only is false, then: // 1. If changingNavigableContinuation's update-only is false, then:
if (!update_only) { if (!update_only) {
// 1. Unload displayedDocument given targetEntry's document. // 1. If targetEntry's document does not equal displayedDocument, then:
displayed_document->unload(target_entry->document_state->document()); if (target_entry->document_state->document().ptr() != displayed_document.ptr()) {
// 1. Unload displayedDocument given targetEntry's document.
displayed_document->unload(target_entry->document_state->document());
// 2. For each childNavigable of displayedDocument's descendant navigables, queue a global task on the navigation and traversal task source given // 2. For each childNavigable of displayedDocument's descendant navigables, queue a global task on the navigation and traversal task source given
// childNavigable's active window to unload childNavigable's active document. // childNavigable's active window to unload childNavigable's active document.
for (auto child_navigable : displayed_document->descendant_navigables()) { for (auto child_navigable : displayed_document->descendant_navigables()) {
queue_global_task(Task::Source::NavigationAndTraversal, *navigable->active_window(), [child_navigable] { queue_global_task(Task::Source::NavigationAndTraversal, *navigable->active_window(), [child_navigable] {
child_navigable->active_document()->unload(); child_navigable->active_document()->unload();
}); });
}
} }
// 3. Activate history entry targetEntry for navigable. // 3. Activate history entry targetEntry for navigable.