RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 12:37:44 +00:00
Code Issues Activity Actions

LibWeb: Fix box-shadows where the border-radius is < the blur-radius

Browse source 
This fixes a rendering issue where box-shadows would not appear or
render completely broken if the blur radius was larger than the
border radius (border-radius < 2 * blur-radius to be exact).
This commit is contained in:
MacDue 2022-12-05 00:02:48 +00:00 • committed by Andreas Kling
parent ca123350cc
commit 385ba1280b
1 changed files with 13 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

24
Userland/Libraries/LibWeb/Painting/ShadowPainting.cpp
View file

@ -99,19 +99,21 @@ void paint_box_shadow(PaintContext& context, Gfx::IntRect const& content_rect, B
auto extra_edge_width = non_blurred_shadow_rect.width() % 2; auto extra_edge_width = non_blurred_shadow_rect.width() % 2;
auto extra_edge_height = non_blurred_shadow_rect.height() % 2; auto extra_edge_height = non_blurred_shadow_rect.height() % 2;
auto clip_corner_size = [&](auto& size, int x_bonus = 0, int y_bonus = 0) { auto clip_corner_size = [&](auto& size, auto const& corner, int x_bonus = 0, int y_bonus = 0) {
size.set_width(min(size.width(), max_edge_width + x_bonus)); auto max_x = max_edge_width + x_bonus;
size.set_height(min(size.height(), max_edge_height + y_bonus)); auto max_y = max_edge_height + y_bonus;
auto min_x = max(corner.horizontal_radius, min(double_radius, max_x));
auto min_y = max(corner.vertical_radius, min(double_radius, max_y));
if (min_x <= max_x)
size.set_width(clamp(size.width(), min_x, max_x));
if (min_y <= max_y)
size.set_height(clamp(size.height(), min_y, max_y));
}; };
if (!top_left_corner) clip_corner_size(top_left_corner_size, top_left_corner, extra_edge_width, extra_edge_height);
clip_corner_size(top_left_corner_size, extra_edge_width, extra_edge_height); clip_corner_size(top_right_corner_size, top_right_corner, 0, extra_edge_height);
if (!top_right_corner) clip_corner_size(bottom_left_corner_size, bottom_left_corner, extra_edge_width);
clip_corner_size(top_right_corner_size, 0, extra_edge_height); clip_corner_size(bottom_right_corner_size, bottom_right_corner);
if (!bottom_left_corner)
clip_corner_size(bottom_left_corner_size, extra_edge_width);
if (!bottom_right_corner)
clip_corner_size(bottom_right_corner_size);
auto shadow_bitmap_rect = Gfx::IntRect( auto shadow_bitmap_rect = Gfx::IntRect(
0, 0, 0, 0,