From 385e9268f4fcc1b54f194993308c0b4b38bf3ddc Mon Sep 17 00:00:00 2001 From: Andreas Kling Date: Thu, 1 Aug 2019 10:41:04 +0200 Subject: [PATCH] CIODevice: printf() thought it was calling ::write() but it was write() There's some confusion between the write syscall and CIODevice::write() here. The internal write() returns a boolean, and has already whined in case the syscall failed, so we don't need to do that again. --- Libraries/LibCore/CIODevice.cpp | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/Libraries/LibCore/CIODevice.cpp b/Libraries/LibCore/CIODevice.cpp index a585e1a8dd..8c8fd57a33 100644 --- a/Libraries/LibCore/CIODevice.cpp +++ b/Libraries/LibCore/CIODevice.cpp @@ -249,9 +249,7 @@ int CIODevice::printf(const char* format, ...) va_start(ap, format); // FIXME: We're not propagating write() failures to client here! int ret = printf_internal([this](char*&, char ch) { - int rc = write((const u8*)&ch, 1); - if (rc < 0) - dbgprintf("CIODevice::printf: write: %s\n", strerror(errno)); + write((const u8*)&ch, 1); }, nullptr, format, ap); va_end(ap);