From 38696dc6269517bcc782eebe5d1490d8755494ac Mon Sep 17 00:00:00 2001 From: Luke Wilde Date: Mon, 11 Jul 2022 14:24:14 +0100 Subject: [PATCH] LibWeb: Store MessageEvent::m_data in a JS::Handle This protects it from GC. --- Userland/Libraries/LibWeb/HTML/MessageEvent.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Userland/Libraries/LibWeb/HTML/MessageEvent.h b/Userland/Libraries/LibWeb/HTML/MessageEvent.h index e08c001eb0..334bfb41aa 100644 --- a/Userland/Libraries/LibWeb/HTML/MessageEvent.h +++ b/Userland/Libraries/LibWeb/HTML/MessageEvent.h @@ -31,20 +31,20 @@ public: virtual ~MessageEvent() override = default; - JS::Value data() const { return m_data; } + JS::Value data() const { return m_data.value(); } String const& origin() const { return m_origin; } String const& last_event_id() const { return m_last_event_id; } protected: MessageEvent(FlyString const& event_name, MessageEventInit const& event_init) : DOM::Event(event_name, event_init) - , m_data(event_init.data) + , m_data(JS::make_handle(event_init.data)) , m_origin(event_init.origin) , m_last_event_id(event_init.last_event_id) { } - JS::Value m_data; + JS::Handle m_data; String m_origin; String m_last_event_id; };