RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 20:27:45 +00:00
Code Issues Activity Actions

LibJS: Store fn pointer to its intrinsic constructor on TypedArrayBase

Browse source 
This represents "the intrinsic object listed in column one of Table X"
in the spec.
This commit is contained in:
Linus Groh 2022-06-26 13:30:33 +01:00
parent e85b3fc750
commit 3885fa1d10
2 changed files with 10 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Userland/Libraries/LibJS/Runtime/TypedArray.cpp
View file

@ -373,7 +373,8 @@ void TypedArrayBase::visit_edges(Visitor& visitor)
} \
\
ClassName::ClassName(Object& prototype, u32 length, ArrayBuffer& array_buffer) \
: TypedArray(prototype, length, array_buffer) \
: TypedArray(prototype, \
reinterpret_cast<TypedArrayBase::IntrinsicConstructor>(&GlobalObject::snake_name##_constructor), length, array_buffer) \
{ \
if constexpr (StringView { #ClassName }.is_one_of("BigInt64Array", "BigUint64Array")) \
m_content_type = ContentType::BigInt; \

11
Userland/Libraries/LibJS/Runtime/TypedArray.h
View file

@ -32,11 +32,14 @@ public:
Number,
};
using IntrinsicConstructor = TypedArrayConstructor* (GlobalObject::*)();
u32 array_length() const { return m_array_length; }
u32 byte_length() const { return m_byte_length; }
u32 byte_offset() const { return m_byte_offset; }
ContentType content_type() const { return m_content_type; }
ArrayBuffer* viewed_array_buffer() const { return m_viewed_array_buffer; }
IntrinsicConstructor intrinsic_constructor() const { return m_intrinsic_constructor; }
void set_array_length(u32 length) { m_array_length = length; }
void set_byte_length(u32 length) { m_byte_length = length; }
@ -58,8 +61,9 @@ public:
virtual Value get_modify_set_value_in_buffer(size_t byte_index, Value value, ReadWriteModifyFunction operation, bool is_little_endian = true) = 0;
protected:
explicit TypedArrayBase(Object& prototype)
TypedArrayBase(Object& prototype, IntrinsicConstructor intrinsic_constructor)
: Object(prototype)
, m_intrinsic_constructor(intrinsic_constructor)
{
}
@ -68,6 +72,7 @@ protected:
u32 m_byte_offset { 0 };
ContentType m_content_type { ContentType::Number };
ArrayBuffer* m_viewed_array_buffer { nullptr };
IntrinsicConstructor m_intrinsic_constructor { nullptr };
private:
virtual void visit_edges(Visitor&) override;
@ -430,8 +435,8 @@ public:
Value get_modify_set_value_in_buffer(size_t byte_index, Value value, ReadWriteModifyFunction operation, bool is_little_endian = true) override { return viewed_array_buffer()->template get_modify_set_value<T>(byte_index, value, move(operation), is_little_endian); }
protected:
TypedArray(Object& prototype, u32 array_length, ArrayBuffer& array_buffer)
: TypedArrayBase(prototype)
TypedArray(Object& prototype, IntrinsicConstructor intrinsic_constructor, u32 array_length, ArrayBuffer& array_buffer)
: TypedArrayBase(prototype, intrinsic_constructor)
{
VERIFY(!Checked<u32>::multiplication_would_overflow(array_length, sizeof(UnderlyingBufferDataType)));
m_viewed_array_buffer = &array_buffer;