RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 23:07:35 +00:00
Code Issues Activity Actions

LibWeb: Don't assert when flex-item has align-self: end

Browse source 
We were missing the code to convert this to `align-items: end`.
This commit is contained in:
Andreas Kling 2023-06-19 16:50:04 +02:00
parent 55c1d8ba29
commit 38a6b7ad3d
3 changed files with 10 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Tests/LibWeb/Layout/expected/flex/align-self-end-crash.txt Normal file
View file

@ -0,0 +1,4 @@
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (0,0) content-size 800x16 [BFC] children: not-inline
Box <body> at (8,8) content-size 784x0 flex-container(row) [FFC] children: not-inline
BlockContainer <div> at (8,8) content-size 0x0 flex-item [BFC] children: not-inline

4
Tests/LibWeb/Layout/input/flex/align-self-end-crash.html Normal file
View file

@ -0,0 +1,4 @@
<!doctype html><style>
body { display: flex; }
div { align-self: end; }
</style><div>

2
Userland/Libraries/LibWeb/Layout/FlexFormattingContext.cpp
View file

@ -1447,6 +1447,8 @@ CSS::AlignItems FlexFormattingContext::alignment_for_item(Box const& box) const
switch (box.computed_values().align_self()) {
case CSS::AlignSelf::Auto:
return flex_container().computed_values().align_items();
case CSS::AlignSelf::End:
return CSS::AlignItems::End;
case CSS::AlignSelf::Normal:
return CSS::AlignItems::Normal;
case CSS::AlignSelf::SelfStart: