RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 13:18:13 +00:00
Code Issues Activity Actions

LibWeb: Make SVGLength and SVGAnimatedLength GC-allocated

Browse source
This commit is contained in:
Andreas Kling 2022-09-02 14:04:59 +02:00
parent 16fbb91aa1
commit 3905d54a9c
14 changed files with 139 additions and 126 deletions
Download patch file Download diff file Expand all files Collapse all files

32
Userland/Libraries/LibWeb/SVG/SVGLineElement.cpp
View file

@ -59,43 +59,43 @@ Gfx::Path& SVGLineElement::get_path()
}
// https://www.w3.org/TR/SVG11/shapes.html#LineElementX1Attribute
NonnullRefPtr<SVGAnimatedLength> SVGLineElement::x1() const
JS::NonnullGCPtr<SVGAnimatedLength> SVGLineElement::x1() const
{
// FIXME: Populate the unit type when it is parsed (0 here is "unknown").
// FIXME: Create a proper animated value when animations are supported.
auto base_length = SVGLength::create(0, m_x1.value_or(0));
auto anim_length = SVGLength::create(0, m_x1.value_or(0));
return SVGAnimatedLength::create(move(base_length), move(anim_length));
auto base_length = SVGLength::create(window(), 0, m_x1.value_or(0));
auto anim_length = SVGLength::create(window(), 0, m_x1.value_or(0));
return SVGAnimatedLength::create(window(), move(base_length), move(anim_length));
}
// https://www.w3.org/TR/SVG11/shapes.html#LineElementY1Attribute
NonnullRefPtr<SVGAnimatedLength> SVGLineElement::y1() const
JS::NonnullGCPtr<SVGAnimatedLength> SVGLineElement::y1() const
{
// FIXME: Populate the unit type when it is parsed (0 here is "unknown").
// FIXME: Create a proper animated value when animations are supported.
auto base_length = SVGLength::create(0, m_y1.value_or(0));
auto anim_length = SVGLength::create(0, m_y1.value_or(0));
return SVGAnimatedLength::create(move(base_length), move(anim_length));
auto base_length = SVGLength::create(window(), 0, m_y1.value_or(0));
auto anim_length = SVGLength::create(window(), 0, m_y1.value_or(0));
return SVGAnimatedLength::create(window(), move(base_length), move(anim_length));
}
// https://www.w3.org/TR/SVG11/shapes.html#LineElementX2Attribute
NonnullRefPtr<SVGAnimatedLength> SVGLineElement::x2() const
JS::NonnullGCPtr<SVGAnimatedLength> SVGLineElement::x2() const
{
// FIXME: Populate the unit type when it is parsed (0 here is "unknown").
// FIXME: Create a proper animated value when animations are supported.
auto base_length = SVGLength::create(0, m_x2.value_or(0));
auto anim_length = SVGLength::create(0, m_x2.value_or(0));
return SVGAnimatedLength::create(move(base_length), move(anim_length));
auto base_length = SVGLength::create(window(), 0, m_x2.value_or(0));
auto anim_length = SVGLength::create(window(), 0, m_x2.value_or(0));
return SVGAnimatedLength::create(window(), move(base_length), move(anim_length));
}
// https://www.w3.org/TR/SVG11/shapes.html#LineElementY2Attribute
NonnullRefPtr<SVGAnimatedLength> SVGLineElement::y2() const
JS::NonnullGCPtr<SVGAnimatedLength> SVGLineElement::y2() const
{
// FIXME: Populate the unit type when it is parsed (0 here is "unknown").
// FIXME: Create a proper animated value when animations are supported.
auto base_length = SVGLength::create(0, m_y2.value_or(0));
auto anim_length = SVGLength::create(0, m_y2.value_or(0));
return SVGAnimatedLength::create(move(base_length), move(anim_length));
auto base_length = SVGLength::create(window(), 0, m_y2.value_or(0));
auto anim_length = SVGLength::create(window(), 0, m_y2.value_or(0));
return SVGAnimatedLength::create(window(), move(base_length), move(anim_length));
}
}