RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 05:07:35 +00:00
Code Issues Activity Actions

AK: Revert removal of StringBuilder::will_append optimization

Browse source 
This was removed as part of the ByteBuffer changes but the allocation
optimization is still necessary at least for non-SerenityOS targets
where malloc_good_size() isn't supported or returns a small value and
causes a whole bunch of unnecessary reallocations.
This commit is contained in:
Gunnar Beutner 2021-05-17 23:18:34 +02:00 • committed by Andreas Kling
parent f91bcb8895
commit 3908a49661
1 changed files with 4 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

5
AK/StringBuilder.cpp
View file

@ -21,7 +21,10 @@ inline void StringBuilder::will_append(size_t size)
Checked<size_t> needed_capacity = m_length; Checked<size_t> needed_capacity = m_length;
needed_capacity += size; needed_capacity += size;
VERIFY(!needed_capacity.has_overflow()); VERIFY(!needed_capacity.has_overflow());
m_buffer.grow(needed_capacity.value()); Checked<size_t> expanded_capacity = needed_capacity;
expanded_capacity *= 2;
VERIFY(!expanded_capacity.has_overflow());
m_buffer.grow(expanded_capacity.value());
} }
StringBuilder::StringBuilder(size_t initial_capacity) StringBuilder::StringBuilder(size_t initial_capacity)