RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 08:27:46 +00:00
Code Issues Activity Actions

Utilities: Use Vector<String> positional arguments in some places

Browse source 
There are more places we can use these, I just picked some that felt
like they improved the code.
This commit is contained in:
Andreas Kling 2021-04-29 11:28:01 +02:00
parent 695cdf7bc0
commit 39369f1da6
6 changed files with 15 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Utilities/checksum.cpp
View file

@ -36,7 +36,7 @@ int main(int argc, char** argv)
auto hash_name = program_name.substring_view(0, program_name.length() - 3).to_string().to_uppercase();
auto paths_help_string = String::formatted("File(s) to print {} checksum of", hash_name);
Vector<const char*> paths;
Vector<String> paths;
Core::ArgsParser args_parser;
args_parser.add_positional_argument(paths, paths_help_string.characters(), "path", Core::ArgsParser::Required::No);
@ -52,8 +52,8 @@ int main(int argc, char** argv)
auto has_error = false;
auto file = Core::File::construct();
for (auto path : paths) {
if (StringView { path } == "-") {
for (auto const& path : paths) {
if (path == "-") {
success = file->open(STDIN_FILENO, Core::IODevice::OpenMode::ReadOnly, Core::File::ShouldCloseFileDescriptor::No);
} else {
file->set_filename(path);