RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 02:37:36 +00:00
Code Issues Activity Actions

Utilities: Use Vector<String> positional arguments in some places

Browse source 
There are more places we can use these, I just picked some that felt
like they improved the code.
This commit is contained in:
Andreas Kling 2021-04-29 11:28:01 +02:00
parent 695cdf7bc0
commit 39369f1da6
6 changed files with 15 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Utilities/gzip.cpp
View file

@ -12,7 +12,7 @@
int main(int argc, char** argv)
{
Vector<const char*> filenames;
Vector<String> filenames;
bool keep_input_files { false };
bool write_to_stdout { false };
@ -25,7 +25,7 @@ int main(int argc, char** argv)
if (write_to_stdout)
keep_input_files = true;
for (const String input_filename : filenames) {
for (auto const& input_filename : filenames) {
auto output_filename = String::formatted("{}.gz", input_filename);
// We map the whole file instead of streaming to reduce size overhead (gzip header) and increase the deflate block size (better compression)