RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 18:57:35 +00:00
Code Issues Activity Actions

Ports: Prevent exporting symbols for ScummVM

Browse source 
Both LibGUI and ScummVM have a GUI::Widget class. This interferes with
normal operation of LibGUI, since the wrong GUI::Widget::~Widget() is
invoked when SerenitySDLWidget (from the SDL2 port) is destructed.

By adding `-fvisibility=hidden` to the compiler flags, we set the
symbol visibility to hidden by default and the correct destructor is
invoked again.
This commit is contained in:
Jelle Raaijmakers 2021-10-18 00:12:28 +02:00 • committed by Linus Groh
parent 59b2bac3a5
commit 3941e4fe24
1 changed files with 11 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

13
Ports/scummvm/package.sh
View file

@ -17,5 +17,14 @@ launcher_category=Games
launcher_command=/usr/local/bin/scummvm launcher_command=/usr/local/bin/scummvm
icon_file=icons/scummvm.ico icon_file=icons/scummvm.ico
export FREETYPE2_CFLAGS="-I${SERENITY_INSTALL_ROOT}/usr/local/include/freetype2" function pre_configure() {
export SDL_CFLAGS="-I${SERENITY_INSTALL_ROOT}/usr/local/include/SDL2" export CPPFLAGS="-fvisibility=hidden"
export FREETYPE2_CFLAGS="-I${SERENITY_INSTALL_ROOT}/usr/local/include/freetype2"
export SDL_CFLAGS="-I${SERENITY_INSTALL_ROOT}/usr/local/include/SDL2"
}
function post_configure() {
unset CPPFLAGS
unset FREETYPE2_CFLAGS
unset SDL_CFLAGS
}