RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 02:07:35 +00:00
Code Issues Activity Actions

AK: Remove test case that doesn't test anything.

Browse source 
Currently, there is no way to check that an assert fails. This test
passes regardless of the assert. (AK/HashTable.h:93)
This commit is contained in:
asynts 2020-08-21 18:31:48 +02:00 • committed by Andreas Kling
parent b306f240a4
commit 39b464dcfd
1 changed files with 5 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

21
AK/Tests/TestHashMap.cpp
View file

@ -26,8 +26,8 @@
#include <AK/TestSuite.h> #include <AK/TestSuite.h>
#include <AK/String.h>
#include <AK/HashMap.h> #include <AK/HashMap.h>
#include <AK/String.h>
TEST_CASE(construct) TEST_CASE(construct)
{ {
@ -88,24 +88,13 @@ TEST_CASE(case_insensitive)
EXPECT_EQ(casemap.size(), 1u); EXPECT_EQ(casemap.size(), 1u);
} }
TEST_CASE(assert_on_iteration_during_clear)
{
struct Object {
~Object()
{
m_map->begin();
}
HashMap<int, Object>* m_map;
};
HashMap<int, Object> map;
map.set(0, { &map });
map.clear();
}
TEST_CASE(hashmap_of_nonnullownptr_get) TEST_CASE(hashmap_of_nonnullownptr_get)
{ {
struct Object { struct Object {
Object(const String& s) : string(s) {} Object(const String& s)
: string(s)
{
}
String string; String string;
}; };