RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 15:38:10 +00:00
Code Issues Activity Actions

LibJS: Make Number.isInteger() test pass on Serenity

Browse source 
The parser doesn't like many decimals, an issue with our strtod()
implementation. Let's use division instead - all tests green again :^)
This commit is contained in:
Linus Groh 2020-04-28 12:39:31 +01:00 • committed by Andreas Kling
parent 1c4d776ccc
commit 3a12a8a348
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Libraries/LibJS/Tests/Number.isInteger.js
View file

@ -8,13 +8,13 @@ try {
assert(Number.isInteger(-10000) === true);
assert(Number.isInteger(5) === true);
assert(Number.isInteger(5.0) === true);
assert(Number.isInteger(5.0000000000000001) === true);
assert(Number.isInteger(5 + 1/10000000000000000) === true);
// FIXME: values outside of i32's range should still return true
// assert(Number.isInteger(+2147483647 + 1) === true);
// assert(Number.isInteger(-2147483648 - 1) === true);
// assert(Number.isInteger(99999999999999999999999999999999999) === true);
assert(Number.isInteger(5.000000000000001) === false);
assert(Number.isInteger(5 + 1/1000000000000000) === false);
assert(Number.isInteger(1.23) === false);
assert(Number.isInteger("") === false);
assert(Number.isInteger("0") === false);