RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-18 19:05:06 +00:00
Code Issues Activity Actions

Kernel/DevPtsFS: Avoid String allocation during directory traversal

Browse source 
Use a StringBuilder to generate a temporary string buffer with the
slave PTY names. (This works because StringBuilder has 128 bytes of
inline stack capacity before it does any heap allocations.)
This commit is contained in:
Andreas Kling 2021-08-16 22:18:18 +02:00
parent 0de8c95d49
commit 3a2d888913
1 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Kernel/FileSystem/DevPtsFS.cpp
View file

@ -118,9 +118,9 @@ KResult DevPtsFSInode::traverse_as_directory(Function<bool(FileSystem::Directory
SlavePTY::all_instances().with([&](auto& list) { SlavePTY::all_instances().with([&](auto& list) {
for (SlavePTY& slave_pty : list) { for (SlavePTY& slave_pty : list) {
String name = String::number(slave_pty.index()); StringBuilder builder;
InodeIdentifier identifier = { fsid(), pty_index_to_inode_index(slave_pty.index()) }; builder.appendff("{}", slave_pty.index());
callback({ name, identifier, 0 }); callback({ builder.string_view(), { fsid(), pty_index_to_inode_index(slave_pty.index()) }, 0 });
} }
}); });