RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-10-31 22:02:44 +00:00
Code Issues Activity Actions

Fix dumb bug in HashTable::clear().

Browse source 
We forgot to clear the m_buckets pointer. This meant that multiple calls to
clear() would cause trouble.
This commit is contained in:
Andreas Kling 2019-01-30 19:32:54 +01:00
parent 2b4374d08e
commit 3a4207b863
2 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Kernel/Ext2FileSystem.cpp
View file

@ -373,9 +373,6 @@ void Ext2FSInode::flush_metadata()
// Unless we're about to go away permanently, invalidate the lookup cache.
if (m_raw_inode.i_links_count != 0) {
LOCKER(m_lock);
// FIXME: Something isn't working right when we hit this code path.
// I've seen crashes inside HashMap::clear() all the way down in DoublyLinkedList::clear().
// My guess would be a HashTable bug.
// FIXME: This invalidation is way too hardcore. It's sad to throw away the whole cache.
m_lookup_cache.clear();
}