RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 08:07:44 +00:00
Code Issues Activity Actions

LibJS: Add spec comments to less_than_equals()

Browse source
This commit is contained in:
Linus Groh 2022-12-10 00:04:46 +00:00
parent e53c8ae593
commit 3a8c704d19
1 changed files with 13 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

15
Userland/Libraries/LibJS/Runtime/Value.cpp
View file

@ -1282,13 +1282,24 @@ ThrowCompletionOr<Value> less_than(VM& vm, Value lhs, Value rhs)
} }
// 13.10 Relational Operators, https://tc39.es/ecma262/#sec-relational-operators // 13.10 Relational Operators, https://tc39.es/ecma262/#sec-relational-operators
// RelationalExpression : RelationalExpression <= ShiftExpression
ThrowCompletionOr<Value> less_than_equals(VM& vm, Value lhs, Value rhs) ThrowCompletionOr<Value> less_than_equals(VM& vm, Value lhs, Value rhs)
{ {
// 1. Let lref be ? Evaluation of RelationalExpression.
// 2. Let lval be ? GetValue(lref).
// 3. Let rref be ? Evaluation of ShiftExpression.
// 4. Let rval be ? GetValue(rref).
// NOTE: This is handled in the AST or Bytecode interpreter.
// OPTIMIZATION: If both values are i32, we can do a direct comparison without calling into IsLessThan.
if (lhs.is_int32() && rhs.is_int32()) if (lhs.is_int32() && rhs.is_int32())
return lhs.as_i32() <= rhs.as_i32(); return lhs.as_i32() <= rhs.as_i32();
TriState relation = TRY(is_less_than(vm, lhs, rhs, false)); // 5. Let r be ? IsLessThan(rval, lval, false).
if (relation == TriState::Unknown || relation == TriState::True) auto relation = TRY(is_less_than(vm, lhs, rhs, false));
// 6. If r is true or undefined, return false. Otherwise, return true.
if (relation == TriState::True || relation == TriState::Unknown)
return Value(false); return Value(false);
return Value(true); return Value(true);
} }