RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 13:17:44 +00:00
Code Issues Activity Actions

Kernel: Use operator ""sv in all purpose() implementations

Browse source 
Previously there was a mix of returning plain strings and returning
explicit string views using `operator ""sv`. This change switches them
all to standardized on `operator ""sv` as it avoids a call to strlen.
This commit is contained in:
Brian Gianforcaro 2021-10-02 15:30:23 -07:00 • committed by Andreas Kling
parent 5f1c98e576
commit 3a945051fc
10 changed files with 11 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Kernel/Interrupts/APIC.cpp
View file

@ -79,7 +79,7 @@ public:
virtual bool eoi() override;
virtual HandlerType type() const override { return HandlerType::IRQHandler; }
virtual StringView purpose() const override { return "IPI Handler"; }
virtual StringView purpose() const override { return "IPI Handler"sv; }
virtual StringView controller() const override { return nullptr; }
virtual size_t sharing_devices_count() const override { return 0; }
@ -110,7 +110,7 @@ public:
virtual bool eoi() override;
virtual HandlerType type() const override { return HandlerType::IRQHandler; }
virtual StringView purpose() const override { return "SMP Error Handler"; }
virtual StringView purpose() const override { return "SMP Error Handler"sv; }
virtual StringView controller() const override { return nullptr; }
virtual size_t sharing_devices_count() const override { return 0; }

2
Kernel/Interrupts/IRQHandler.h
View file

@ -27,7 +27,7 @@ public:
virtual bool eoi() override;
virtual HandlerType type() const override { return HandlerType::IRQHandler; }
virtual StringView purpose() const override { return "IRQ Handler"; }
virtual StringView purpose() const override { return "IRQ Handler"sv; }
virtual StringView controller() const override { return m_responsible_irq_controller->model(); }
virtual size_t sharing_devices_count() const override { return 0; }

2
Kernel/Interrupts/SharedIRQHandler.h
View file

@ -32,7 +32,7 @@ public:
virtual bool is_sharing_with_others() const override { return false; }
virtual HandlerType type() const override { return HandlerType::SharedIRQHandler; }
virtual StringView purpose() const override { return "Shared IRQ Handler"; }
virtual StringView purpose() const override { return "Shared IRQ Handler"sv; }
virtual StringView controller() const override { return m_responsible_irq_controller->model(); }
private:

2
Kernel/Interrupts/SpuriousInterruptHandler.cpp
View file

@ -41,7 +41,7 @@ bool SpuriousInterruptHandler::eoi()
StringView SpuriousInterruptHandler::purpose() const
{
if (!m_real_handler)
return "Spurious Interrupt Handler";
return "Spurious Interrupt Handler"sv;
return m_real_handler->purpose();
}

2
Kernel/Interrupts/UnhandledInterruptHandler.h
View file

@ -21,7 +21,7 @@ public:
[[noreturn]] virtual bool eoi() override;
virtual HandlerType type() const override { return HandlerType::UnhandledInterruptHandler; }
virtual StringView purpose() const override { return "Unhandled Interrupt Handler"; }
virtual StringView purpose() const override { return "Unhandled Interrupt Handler"sv; }
virtual StringView controller() const override { VERIFY_NOT_REACHED(); }
virtual size_t sharing_devices_count() const override { return 0; }