RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 08:57:47 +00:00
Code Issues Activity Actions

LibJS: Convert test_integrity_level() to ThrowCompletionOr

Browse source
This commit is contained in:
Linus Groh 2021-10-03 02:21:44 +01:00
parent ed5a9aa038
commit 3af559ee8a
3 changed files with 7 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Userland/Libraries/LibJS/Runtime/Object.cpp
View file

@ -340,7 +340,7 @@ ThrowCompletionOr<bool> Object::set_integrity_level(IntegrityLevel level)
}
// 7.3.16 TestIntegrityLevel ( O, level ), https://tc39.es/ecma262/#sec-testintegritylevel
bool Object::test_integrity_level(IntegrityLevel level) const
ThrowCompletionOr<bool> Object::test_integrity_level(IntegrityLevel level) const
{
// 1. Assert: Type(O) is Object.
@ -348,7 +348,7 @@ bool Object::test_integrity_level(IntegrityLevel level) const
VERIFY(level == IntegrityLevel::Sealed || level == IntegrityLevel::Frozen);
// 3. Let extensible be ? IsExtensible(O).
auto extensible = TRY_OR_DISCARD(is_extensible());
auto extensible = TRY(is_extensible());
// 4. If extensible is true, return false.
// 5. NOTE: If the object is extensible, none of its properties are examined.
@ -356,14 +356,14 @@ bool Object::test_integrity_level(IntegrityLevel level) const
return false;
// 6. Let keys be ? O.[[OwnPropertyKeys]]().
auto keys = TRY_OR_DISCARD(internal_own_property_keys());
auto keys = TRY(internal_own_property_keys());
// 7. For each element k of keys, do
for (auto& key : keys) {
auto property_name = PropertyName::from_value(global_object(), key);
// a. Let currentDesc be ? O.[[GetOwnProperty]](k).
auto current_descriptor = TRY_OR_DISCARD(internal_get_own_property(property_name));
auto current_descriptor = TRY(internal_get_own_property(property_name));
// b. If currentDesc is not undefined, then
if (!current_descriptor.has_value())

2
Userland/Libraries/LibJS/Runtime/Object.h
View file

@ -86,7 +86,7 @@ public:
ThrowCompletionOr<bool> has_property(PropertyName const&) const;
ThrowCompletionOr<bool> has_own_property(PropertyName const&) const;
ThrowCompletionOr<bool> set_integrity_level(IntegrityLevel);
bool test_integrity_level(IntegrityLevel) const;
ThrowCompletionOr<bool> test_integrity_level(IntegrityLevel) const;
MarkedValueList enumerable_own_property_names(PropertyKind kind) const;
ThrowCompletionOr<Object*> copy_data_properties(Value source, HashTable<PropertyName, PropertyNameTraits> const& seen_names, GlobalObject& global_object);

4
Userland/Libraries/LibJS/Runtime/ObjectConstructor.cpp
View file

@ -188,7 +188,7 @@ JS_DEFINE_NATIVE_FUNCTION(ObjectConstructor::is_frozen)
auto argument = vm.argument(0);
if (!argument.is_object())
return Value(true);
return Value(argument.as_object().test_integrity_level(Object::IntegrityLevel::Frozen));
return Value(TRY_OR_DISCARD(argument.as_object().test_integrity_level(Object::IntegrityLevel::Frozen)));
}
// 20.1.2.16 Object.isSealed ( O ), https://tc39.es/ecma262/#sec-object.issealed
@ -197,7 +197,7 @@ JS_DEFINE_NATIVE_FUNCTION(ObjectConstructor::is_sealed)
auto argument = vm.argument(0);
if (!argument.is_object())
return Value(true);
return Value(argument.as_object().test_integrity_level(Object::IntegrityLevel::Sealed));
return Value(TRY_OR_DISCARD(argument.as_object().test_integrity_level(Object::IntegrityLevel::Sealed)));
}
// 20.1.2.18 Object.preventExtensions ( O ), https://tc39.es/ecma262/#sec-object.preventextensions