mirror of
https://github.com/RGBCube/serenity
synced 2025-07-25 02:37:42 +00:00
LibCore+Everywhere: Make Core::Stream::read() return Bytes
A mistake I've repeatedly made is along these lines: ```c++ auto nread = TRY(source_file->read(buffer)); TRY(destination_file->write(buffer)); ``` It's a little clunky to have to create a Bytes or StringView from the buffer's data pointer and the nread, and easy to forget and just use the buffer. So, this patch changes the read() function to return a Bytes of the data that were just read. The other read_foo() methods will be modified in the same way in subsequent commits. Fixes #13687
This commit is contained in:
parent
6654efcd82
commit
3b1e063d30
22 changed files with 103 additions and 103 deletions
|
@ -259,8 +259,8 @@ inline ErrorOr<JsonValue> read_json_file(StringView path)
|
|||
|
||||
// FIXME: When Core::Stream supports reading an entire file, use that.
|
||||
while (TRY(file->can_read_line())) {
|
||||
auto nread = TRY(file->read(buffer));
|
||||
TRY(builder.try_append(reinterpret_cast<char const*>(buffer.data()), nread));
|
||||
auto bytes_read = TRY(file->read(buffer));
|
||||
TRY(builder.try_append(StringView { bytes_read }));
|
||||
}
|
||||
|
||||
return JsonValue::from_string(builder.build());
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue